Fixbug save_pclouds.py #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.Fix wrong type : WindowPath -> str(path) for np.loadtxt 2.Fix wrong rgb, depth file path 3. 'is not' keyword seems to make warnnig in python 3.8 4. default state of parameter 'disable_project_pinhole' in 'save_pclouds()' changed to true.
The point cloud will be overwrited If it already exists.
|
|
buqing2009
suggested changes
Sep 29, 2020
| rgb_tmp = Path(rgb_parts[1]) / Path(rgb_parts[2]) | ||
| depth_parts = Path(depth_proj_path).parts[2:] | ||
| depth_parts = Path(depth_proj_path).parts[3:] | ||
| depth_tmp = Path(depth_parts[1]) / Path(depth_parts[2]) | ||
|
|
There was a problem hiding this comment.
the path of everyone is not the same, so the best solution is as follows:
rgb_parts = Path(rgb_proj_path).parts[2:]
rgb_tmp = Path(rgb_parts[-2]) / Path(rgb_parts[-1])
depth_parts = Path(depth_proj_path).parts[2:]
depth_tmp = Path(depth_parts[-2]) / Path(depth_parts[-1])
And tsdf-integration.py can be run correctly
There was a problem hiding this comment.
Yes, The filepath seems to be different for each OS.
Your code works well in windows10, I haven't tried it for other OS, but it will probably work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found bugs since I try to run tsdf script. The bugs is made by save_pclouds.py script.
Please confirm my reports. (It's only tested in Windows 10)
1.Fix wrong type : WindowPath -> str(path) on np.loadtxt()
2.Fix wrong generation code : rgb, depth filepath in [pinhole_projection/depth.txt, rgb.txt]
3. 'is not' keyword seems to make warnnig in python 3.8
4. default state of parameter 'disable_project_pinhole' in 'save_pclouds()' changed to true.
5. remove 'skip code' of generating .ply if it already exist. So files in 'pinhole_projection' will be overwrited if it is already exists.
Nevertheless, The reason why it need to be overwrited is that original code have possibility to create bug that it also does not create right .txt files(rgb,depth,odometry,trajectory...) if .ply was already generated by other script.