Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change "Group Management" to "Device Group" #292

Merged
merged 2 commits into from
Feb 23, 2023
Merged

change "Group Management" to "Device Group" #292

merged 2 commits into from
Feb 23, 2023

Conversation

hydraxman
Copy link
Member

@hydraxman hydraxman commented Feb 22, 2023 •
edited

image

RaccoonLi
RaccoonLi reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@RaccoonLi RaccoonLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May also update the filename from GroupManageView to DeviceGroupView.jsx

@hydraxman hydraxman enabled auto-merge (squash) February 23, 2023 01:23
RaccoonLi
RaccoonLi approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@RaccoonLi RaccoonLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hydraxman hydraxman merged commit 06c8317 into main Feb 23, 2023
@hydraxman hydraxman deleted the dev/hydraxman/fix_name branch February 23, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaccoonLi RaccoonLi RaccoonLi approved these changes

@lifesaver0129 lifesaver0129 Awaiting requested review from lifesaver0129 lifesaver0129 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hydraxman @RaccoonLi