Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Add performance history chart #409

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Conversation

taoran6
Copy link
Collaborator

@taoran6 taoran6 commented Apr 4, 2023

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

  • Yes
  • No

Pull Request Description

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe):

#TODO
Show perf history with multi-page rather than only 10 dots.

A few words to explain your changes:

Issue ID: #

How you tested it

Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.
Run the front-end project and the history chart can be seen at the portal

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...
image

@taoran6 taoran6 merged commit 19921c3 into main Apr 4, 2023
5 checks passed
@taoran6 taoran6 deleted the taoran/perf_history_chart branch April 4, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants