Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle plugin: extract retry methods of API calling #590

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

olivershen-wow
Copy link
Contributor

Description

Gradle plugin: extract retry methods of API calling, so that the first failed request attempt would also retry.

Linked GitHub issue ID:

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

  • Yes
  • No

How you tested it

Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Technical design
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe):

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...

@olivershen-wow olivershen-wow marked this pull request as ready for review September 12, 2023 02:41
@olivershen-wow olivershen-wow changed the title Extract retry methods of API calling Gradle plugin: extract retry methods of API calling Sep 12, 2023
@olivershen-wow olivershen-wow enabled auto-merge (squash) September 12, 2023 02:44
@olivershen-wow
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@olivershen-wow olivershen-wow merged commit 7e7a1ce into main Sep 12, 2023
5 checks passed
@olivershen-wow olivershen-wow deleted the user/lsh/gradle-plugin-request-issue branch September 12, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants