Compression level validation #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangbingsyb
requested review from
bariscaglar,
shirhatti,
mcy94w,
pan-wang,
jhkimnew and
jimmyca15
|
Configured iiszlib with compression level 12, and tested the event and the response:
|
pan-wang
approved these changes
Sep 29, 2018
iisbrotli/iisbrotli.cpp
Outdated
| // so only the upper bound needs to be checked. | ||
| if (compression_level > BROTLI_MAX_QUALITY) | ||
| { | ||
| hr = ReportCompressionLevelOutOfBounds(compression_level, BROTLI_MAX_QUALITY); |
There was a problem hiding this comment.
no need this hr assignment as you assign the value later
iisbrotli/iisbrotli.cpp
Outdated
| // so only the upper bound needs to be checked. | ||
| if (compression_level > BROTLI_MAX_QUALITY) | ||
| { | ||
| hr = ReportCompressionLevelOutOfBounds(compression_level, BROTLI_MAX_QUALITY); |
iiszlib/iiszlib.cxx
Outdated
| // so only the upper bound needs to be checked. | ||
| if (compression_level > Z_BEST_COMPRESSION) | ||
| { | ||
| hr = ReportCompressionLevelOutOfBounds(compression_level, Z_BEST_COMPRESSION); |
iiszlib/iiszlib.cxx
Outdated
| // so only the upper bound needs to be checked. | ||
| if (compression_level > Z_BEST_COMPRESSION) | ||
| { | ||
| hr = ReportCompressionLevelOutOfBounds(compression_level, Z_BEST_COMPRESSION); |
|
@pan-wang Removed the redundant hr assignment. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is made to address: #15
iiszlib.dll has maximum allowable compression level 9, while the inbox gzip.dll has maximum level 10. This can not only cause confusion, but also zlib library directly crashes if the passed-in compression level is larger than 9. It would be extremely hard for users to figure out the root cause once the crash happens.
Main changes in the PR:
Other changes:
Future changes:
To let event viewer properly parse the message data, we need to set the following registries:
HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\Eventlog\IIS Zlib:
EventMessageFile (REG_EXPAND_SZ): C:\Program Files\IIS\IIS Compression\iiszlib.dll
TypesSupported (REG_DWORD): 7
HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\Eventlog\IIS Brotli:
EventMessageFile (REG_EXPAND_SZ): C:\Program Files\IIS\IIS Compression\iisbrotli.dll
TypesSupported (REG_DWORD): 7
We need to update the installer of IIS Compression to write these registries.