This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Add histopathology module and add hi-ml as submodule #603

Merged

mebristo merged 24 commits into main from mebristo/move_histopathology_2

Dec 6, 2021

Member

mebristo commented Dec 2, 2021

Add histopathology module
Add hi-ml as submodule (for quicker development across libraries)

Please follow the guidelines for PRs contained here. Checklist:

Ensure that your PR is small, and implements one change.
Add unit tests for all functions that you introduced or modified.
Run PyCharm's code cleanup tools on your Python files.
Link the correct GitHub issue for tracking.
Update the Changelog file: Describe your change in terms of
Added/Changed/Removed/... in the "Upcoming" section.
When merging your PR, replace the default merge message with a description of your PR,
and if needed a motivation why that change was required.

mebristo added 4 commits

December 1, 2021 11:26


          Add hi-ml submodule

a4b288d


          Add Histopathology module

fb862be


          Add tests

f790d8d


          update azure scripts

a960f80

mebristo requested a review from ant0nsc

December 2, 2021 09:42

ant0nsc previously approved these changes

View reviewed changes

InnerEye/ML/Histopathology/datamodules/base_module.py Outdated Show resolved Hide resolved

InnerEye/ML/Histopathology/datamodules/base_module.py Outdated Show resolved Hide resolved

vale-salvatelli reviewed

View reviewed changes

InnerEye/ML/Histopathology/datamodules/tcga_crck_module.py Show resolved Hide resolved

vale-salvatelli reviewed

View reviewed changes

InnerEye/ML/Histopathology/datasets/base_dataset.py Show resolved Hide resolved

vale-salvatelli reviewed

View reviewed changes

InnerEye/ML/Histopathology/notebooks/Explore_PANDA.ipynb Outdated Show resolved Hide resolved

vale-salvatelli reviewed

View reviewed changes

InnerEye/ML/Histopathology/notebooks/dummy.ipynb Outdated Show resolved Hide resolved

vale-salvatelli reviewed

View reviewed changes

InnerEye/ML/Histopathology/notebooks/explore_tcga_crck.ipynb Outdated Show resolved Hide resolved

vale-salvatelli reviewed

View reviewed changes

InnerEye/ML/Histopathology/notebooks/explore_encoded_features.ipynb Outdated Show resolved Hide resolved

vale-salvatelli reviewed

View reviewed changes

InnerEye/ML/Histopathology/utils/download_utils.py Show resolved Hide resolved

vale-salvatelli reviewed

View reviewed changes

InnerEye/ML/Histopathology/utils/layer_utils.py Show resolved Hide resolved

vale-salvatelli reviewed

View reviewed changes

Tests/ML/histopathology/test_datamodule_caching.py Outdated Show resolved Hide resolved


          Address PR comments

f3f6dd2

mebristo dismissed ant0nsc’s stale review via

f3f6dd2

December 2, 2021 18:23

mebristo added 2 commits

December 2, 2021 18:25


          mypy

816fd89


          Add changelog

56b32ac

mebristo marked this pull request as ready for review

December 2, 2021 18:30

javier-alvarez force-pushed the mebristo/move_histopathology_2 branch 4 times, most recently from b9efc17 to 3de388b Compare

December 2, 2021 21:01


          Add hi-ml submodule

c6ad609

Add Histopathology module

Add tests

update azure scripts

Address PR comments

mypy

Add changelog

Changes label

javier-alvarez force-pushed the mebristo/move_histopathology_2 branch from 3de388b to c6ad609 Compare

December 2, 2021 21:06

mebristo added 4 commits

December 3, 2021 09:47


          turn off logging outside of AML for now to get tests to pass

d1faac3


          fix merge conflict

a653238


          flake8

419de73


          Merge branch 'main' of https://github.com/microsoft/InnerEye-DeepLear…

…ning into mebristo/move_histopathology_2

mebristo added 9 commits

December 3, 2021 18:15


          flake8

1f8c146


          flake8

9dbd060


          Bug in init file

98f217b


          eclude histopathology datasets module from amlignore

5abf244


          exclude histopathology datasets module from amlignore

818436f


          exclude histopathology datasets module from amlignore

eb5def8


          exclude histopathology datasets module from amlignore

80647cf


          exclude histopathology datasets module from gitignore

a019c15


          exclude histopathology datasets module from gitignore

7ea73c8

ant0nsc previously approved these changes

View reviewed changes

.gitignore Show resolved Hide resolved

vale-salvatelli reviewed

View reviewed changes

environment.yml Outdated Show resolved Hide resolved

environment.yml Show resolved Hide resolved

Tests/ML/histopathology/models/test_encoders.py Outdated Show resolved Hide resolved

Tests/ML/histopathology/models/test_encoders.py Outdated Show resolved Hide resolved


          Address PR comments

c53764b

mebristo dismissed ant0nsc’s stale review via

c53764b

December 6, 2021 14:44

mebristo added 2 commits

December 6, 2021 15:18


          Address PR comments

cda7302


          Minor change to requeue build

e56b6aa

ant0nsc approved these changes

View reviewed changes

vale-salvatelli approved these changes

View reviewed changes

mebristo merged commit 71b6445 into main

mebristo deleted the mebristo/move_histopathology_2 branch

December 6, 2021 17:23

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.