Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Updated README.md #680

Merged
merged 3 commits into from
Mar 3, 2022
Merged

Updated README.md #680

merged 3 commits into from
Mar 3, 2022

Conversation

ktakeda1
Copy link
Contributor

@ktakeda1 ktakeda1 commented Mar 1, 2022

Added acknowledgements section

Write a detailed description of your PR here.

Please follow the guidelines for PRs contained here. Checklist:

  • Ensure that your PR is small, and implements one change.
  • Add unit tests for all functions that you introduced or modified.
  • Run PyCharm's code cleanup tools on your Python files.
  • Link the correct GitHub issue for tracking.
  • Update the Changelog file: Describe your change in terms of
    Added/Changed/Removed/... in the "Upcoming" section.
  • When merging your PR, replace the default merge message with a description of your PR,
    and if needed a motivation why that change was required.

Added acknowledgements section
Copy link
Contributor Author

@ktakeda1 ktakeda1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledgement text prettified and URL made live

@fepegar
Copy link
Contributor

fepegar commented Mar 3, 2022

Apologies for the many changes in my commit, that was my IDE cleaning up trailing whitespaces. I just meant to fix a typo and format the citation!

@javier-alvarez javier-alvarez added the no changelog needed CHANGELOG.md does not need to be updated in this PR label Mar 3, 2022
javier-alvarez
javier-alvarez previously approved these changes Mar 3, 2022
@javier-alvarez javier-alvarez enabled auto-merge (squash) March 3, 2022 15:37
@fepegar fepegar self-requested a review March 3, 2022 15:38
fepegar
fepegar previously approved these changes Mar 3, 2022
@fepegar fepegar disabled auto-merge March 3, 2022 16:01
@fepegar fepegar dismissed stale reviews from javier-alvarez and themself via 8e1e5ce March 3, 2022 16:13
@fepegar fepegar enabled auto-merge (squash) March 3, 2022 16:45
@fepegar fepegar requested a review from ant0nsc March 3, 2022 16:45
@fepegar fepegar merged commit a4c82df into main Mar 3, 2022
@fepegar fepegar deleted the ktakeda1-README-acknowledgements branch March 3, 2022 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no changelog needed CHANGELOG.md does not need to be updated in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants