Added LightGBM JAVA SWIG wrapper support for windows #1599

imatiach-msft · 2018-08-22T05:54:20Z

Added LightGBM JAVA SWIG wrapper support for windows OS
TODO: Add to Mac OS (need to find a Mac to validate this on)

To validate on windows (note, you must have SWIG and java sdk installed and JAVA_HOME environment variable must be set):

mkdir build
cd build
cmake -DCMAKE_GENERATOR_PLATFORM=x64 -DUSE_SWIG=ON ..
cmake --build . --target ALL_BUILD --config Release

StrikerRUS · 2018-08-22T10:26:07Z

Hi @imatiach-msft !

Is it possible to make the following minor fix for Linux in this PR too?

Also I think it'll good to set _lightgbm_swig as default target of make command when compiling with -DUSE_SWIG=ON flag, so that users will be able not to type make _lightgbm_swig, but just make.

And what about MinGW on Windows? Should it work potentially?

UPD:

TODO: Add to Mac OS (need to find a Mac to validate this on)

I believe that someone with macOS from #1326 can help to test.

imatiach-msft · 2018-08-24T04:49:53Z

@StrikerRUS sorry I'm not sure how to fix the aliasing errors - all of the SWIG code is autogenerated. What is the preferred way to fix them, for example for this error:

/home/travis/build/Microsoft/LightGBM/build/java/lightgbmlibJAVA_wrap.cxx:615:29: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
   arg3 = *(DatasetHandle *)&jarg3;

my guess is that I should change the generated code to instead look like:

   arg3 = (DatasetHandle)jarg3;

imatiach-msft · 2018-08-24T04:50:34Z

mingw should work but I haven't tested it yet

imatiach-msft · 2018-08-24T05:34:49Z

@StrikerRUS I ran it with mingw on windows but I got this error, for some reason the swig dll was not generated (I do see the lightgbm dll however):

[100%] Linking CXX shared module ..\lib_lightgbm_swig.dll
process_begin: CreateProcess(NULL, cp C:/LightGBM/LightGBM/Release/*.dll com/microsoft/ml/lightgbm/windows/x86_64, ...)
failed.
make (e=2): The system cannot find the file specified.
mingw32-make[2]: *** [CMakeFiles\_lightgbm_swig.dir\build.make:89: ../lib_lightgbm_swig.dll] Error 2
mingw32-make[2]: *** Deleting file '../lib_lightgbm_swig.dll'
mingw32-make[1]: *** [CMakeFiles\Makefile2:68: CMakeFiles/_lightgbm_swig.dir/all] Error 2
mingw32-make: *** [Makefile:129: all] Error 2

imatiach-msft · 2018-08-24T05:49:57Z

@StrikerRUS hmm, actually it seems that it is deleting the lib_lightgbm_swig.dll, it looks like when compiling in mingw there is no "Release" directory generated and this fails:
COMMAND cp "${PROJECT_SOURCE_DIR}/Release/*.dll" com/microsoft/ml/lightgbm/windows/x86_64

StrikerRUS · 2018-08-24T10:17:37Z

@imatiach-msft Yeah, MinGW places generated files right into the root folder of the project.

The exe and dll files will be in LightGBM/ folder.

(https://lightgbm.readthedocs.io/en/latest/Installation-Guide.html#mingw-w64)

As for warnings, lets leave them for another PR.
Sorry, probably my #1599 (comment) was unclear, but under the minor fix I meant the following:

Also I think it'll good to set _lightgbm_swig as default target of make command when compiling with -DUSE_SWIG=ON flag, so that users will be able not to type make _lightgbm_swig, but just make.

imatiach-msft · 2018-08-24T15:09:04Z

@StrikerRUS I was getting errors even when I removed the Release dir last night, maybe it has to do with how I installed mingw, I specified threads=posix (the default) whereas I should have specified win32 (?)

StrikerRUS · 2018-08-24T15:20:16Z

We run tests with POSIX threads too...
https://github.com/Microsoft/LightGBM/blob/dcf9ad2eb9c62dfe347cd249648459500df9d6e6/.appveyor.yml#L19

I was getting errors even when I removed the Release dir last night,

Which one?

imatiach-msft · 2018-08-24T15:22:19Z

even if I do this it seems to complain:

  if(WIN32)
    if(MINGW OR CYGWIN)
        add_custom_command(TARGET _lightgbm_swig POST_BUILD
	        COMMAND "${Java_JAVAC_EXECUTABLE}" -d . java/*.java
	        COMMAND cp "*" "com"
	        COMMAND "${Java_JAR_EXECUTABLE}" -cf lightgbmlib.jar com)
    else()
        add_custom_command(TARGET _lightgbm_swig POST_BUILD
	        COMMAND "${Java_JAVAC_EXECUTABLE}" -d . java/*.java
	        COMMAND cp "${PROJECT_SOURCE_DIR}/Release/*.dll" com/microsoft/ml/lightgbm/windows/x86_64
	        COMMAND "${Java_JAR_EXECUTABLE}" -cf lightgbmlib.jar com)
    endif()
  else()
    add_custom_command(TARGET _lightgbm_swig POST_BUILD
	    COMMAND "${Java_JAVAC_EXECUTABLE}" -d . java/*.java
	    COMMAND cp "${PROJECT_SOURCE_DIR}/*.so" com/microsoft/ml/lightgbm/linux/x86_64
	    COMMAND "${Java_JAR_EXECUTABLE}" -cf lightgbmlib.jar com)
  endif()

that's just copying everything to com folder... it seems it doesn't recognize com folder, weird

imatiach-msft · 2018-08-24T15:23:13Z

I tried reinstalling mingw with win32 and running this but it didn't make a difference, seems that option doesn't have anything to do with paths (just with the threading library)

StrikerRUS · 2018-08-24T15:42:37Z

Can you please try this fix?
https://github.com/Microsoft/LightGBM/blob/dcf9ad2eb9c62dfe347cd249648459500df9d6e6/.appveyor.yml#L18

imatiach-msft · 2018-08-24T15:45:36Z

is the fix to remove git\usr\bin from path?

imatiach-msft · 2018-08-24T15:50:09Z

also, how do I set:

set _lightgbm_swig as default target of make command

I tried the following:
add_library(_lightgbm_swig ${SOURCES})
the build complained though

StrikerRUS · 2018-08-24T15:50:10Z

Yep!

Are you running tests at Appveyor, not locally?

imatiach-msft · 2018-08-24T15:51:39Z

even when I removed from path and rebuilt I still got the error, here is my path:

PS C:\LightGBM\LightGBM\build> $env:PATH
C:\Program Files\Docker\Docker\Resources\bin;C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\ProgramData\Ora
cle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:
\Program Files\Microsoft SQL Server\110\Tools\Binn\;C:\Users\ilmat\.dnx\bin;C:\Program Files\Microsoft DNX\Dnvm\;C:\Prog
ram Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files\nodejs\;C:\Program Files\Git\cmd;C:\Program Files\Git\mi
ngw64\bin;C:\Program Files\dotnet\;C:\Program Files\SourceGear\Common\DiffMerge\;C:\Program Files\CMake\bin;C:\WINDOWS\S
ystem32\OpenSSH\;C:\Program Files\Microsoft VS Code\bin;C:\Program Files (x86)\Microsoft SQL Server\Client SDK\ODBC\130\
Tools\Binn\;C:\Program Files (x86)\Microsoft SQL Server\140\Tools\Binn\;C:\Program Files (x86)\Microsoft SQL Server\140\
DTS\Binn\;C:\Program Files (x86)\Microsoft SQL Server\140\Tools\Binn\ManagementStudio\;C:\Users\ilmat\AppData\Local\Cont
inuum\Miniconda3;C:\Users\ilmat\AppData\Local\Continuum\Miniconda3\Scripts;C:\Users\ilmat\AppData\Local\Continuum\Minico
nda3\Library\bin;C:\Users\ilmat\AppData\Local\Microsoft\WindowsApps;C:\Users\ilmat\AppData\Roaming\npm;C:\Users\ilmat\Ap
pData\Local\Programs\Fiddler;C:\Users\ilmat\Documents\swigwin-3.0.12;C:\Users\ilmat\AppData\Local\Microsoft\WindowsApps;
C:\Program Files\mingw-w64\x86_64-8.1.0-posix-seh-rt_v6-rev0\mingw64\bin

this is the error:

process_begin: CreateProcess(NULL, cp C:/LightGBM/LightGBM/*.dll com/microsoft/ml/lightgbm/windows/x86_64, ...) failed.
make (e=2): The system cannot find the file specified.
mingw32-make[2]: *** [CMakeFiles\_lightgbm_swig.dir\build.make:89: ../lib_lightgbm_swig.dll] Error 2
mingw32-make[2]: *** Deleting file '../lib_lightgbm_swig.dll'
mingw32-make[1]: *** [CMakeFiles\Makefile2:68: CMakeFiles/_lightgbm_swig.dir/all] Error 2
mingw32-make: *** [Makefile:129: all] Error 2

imatiach-msft · 2018-08-24T15:54:41Z

Are you running tests at Appveyor, not locally?

I'm not running any tests I'm just trying to build lightgbm locally. I'm just running everything through powershell on my local machine.

StrikerRUS · 2018-08-24T15:58:44Z

Maybe this one item in your PATH interrupts:

C:\Program Files\Git\mingw64\bin

?

I'm just running everything through powershell.

Got it! That fix affects only our test builds at Appveyor. It's like a tests script for CI service, and it's not connected with the LightGBM building process itself.

imatiach-msft · 2018-08-24T16:04:12Z

still failing, this is the new path:

PS C:\LightGBM\LightGBM\build> $env:PATH
C:\Program Files\Docker\Docker\Resources\bin;C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\ProgramData\Ora
cle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:
\Program Files\Microsoft SQL Server\110\Tools\Binn\;C:\Users\ilmat\.dnx\bin;C:\Program Files\Microsoft DNX\Dnvm\;C:\Prog
ram Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files\nodejs\;C:\Program Files\Git\cmd;C:\Program Files\dotnet
\;C:\Program Files\SourceGear\Common\DiffMerge\;C:\Program Files\CMake\bin;C:\WINDOWS\System32\OpenSSH\;C:\Program Files
\Microsoft VS Code\bin;C:\Program Files (x86)\Microsoft SQL Server\Client SDK\ODBC\130\Tools\Binn\;C:\Program Files (x86
)\Microsoft SQL Server\140\Tools\Binn\;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn\;C:\Program Files (x86)\
Microsoft SQL Server\140\Tools\Binn\ManagementStudio\;C:\Users\ilmat\AppData\Local\Continuum\Miniconda3;C:\Users\ilmat\A
ppData\Local\Continuum\Miniconda3\Scripts;C:\Users\ilmat\AppData\Local\Continuum\Miniconda3\Library\bin;C:\Users\ilmat\A
ppData\Local\Microsoft\WindowsApps;C:\Users\ilmat\AppData\Roaming\npm;C:\Users\ilmat\AppData\Local\Programs\Fiddler;C:\U
sers\ilmat\Documents\swigwin-3.0.12;C:\Users\ilmat\AppData\Local\Microsoft\WindowsApps;C:\Program Files\mingw-w64\x86_64
-8.1.0-posix-seh-rt_v6-rev0\mingw64\bin

same error:

process_begin: CreateProcess(NULL, cp C:/LightGBM/LightGBM/*.dll com/microsoft/ml/lightgbm/windows/x86_64, ...) failed.
make (e=2): The system cannot find the file specified.
mingw32-make[2]: *** [CMakeFiles\_lightgbm_swig.dir\build.make:89: ../lib_lightgbm_swig.dll] Error 2
mingw32-make[2]: *** Deleting file '../lib_lightgbm_swig.dll'
mingw32-make[1]: *** [CMakeFiles\Makefile2:68: CMakeFiles/_lightgbm_swig.dir/all] Error 2
mingw32-make: *** [Makefile:129: all] Error 2

StrikerRUS · 2018-08-24T16:07:38Z

My assumption is that it cannot find cp command rather than com or any other folder...

Try to set C:\Program Files\mingw-w64\x86_64 -8.1.0-posix-seh-rt_v6-rev0\mingw64\bin as first entry in the PATH.

imatiach-msft · 2018-08-24T16:12:53Z

here's the new path:

PS C:\LightGBM\LightGBM\build> $env:Path
C:\Program Files\mingw-w64\x86_64-8.1.0-posix-seh-rt_v6-rev0\mingw64\bin;C:\Program Files\Docker\Docker\Resources\bin;C:
\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOW
S;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Microsoft SQL Server\110\Tools\B
inn\;C:\Users\ilmat\.dnx\bin;C:\Program Files\Microsoft DNX\Dnvm\;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;
C:\Program Files\nodejs\;C:\Program Files\Git\cmd;C:\Program Files\dotnet\;C:\Program Files\SourceGear\Common\DiffMerge\
;C:\Program Files\CMake\bin;C:\WINDOWS\System32\OpenSSH\;C:\Program Files\Microsoft VS Code\bin;C:\Program Files (x86)\M
icrosoft SQL Server\Client SDK\ODBC\130\Tools\Binn\;C:\Program Files (x86)\Microsoft SQL Server\140\Tools\Binn\;C:\Progr
am Files (x86)\Microsoft SQL Server\140\DTS\Binn\;C:\Program Files (x86)\Microsoft SQL Server\140\Tools\Binn\ManagementS
tudio\;C:\Users\ilmat\AppData\Local\Continuum\Miniconda3;C:\Users\ilmat\AppData\Local\Continuum\Miniconda3\Scripts;C:\Us
ers\ilmat\AppData\Local\Continuum\Miniconda3\Library\bin;C:\Users\ilmat\AppData\Local\Microsoft\WindowsApps;C:\Users\ilm
at\AppData\Roaming\npm;C:\Users\ilmat\AppData\Local\Programs\Fiddler;C:\Users\ilmat\Documents\swigwin-3.0.12;C:\Users\il
mat\AppData\Local\Microsoft\WindowsApps

same error:

[100%] Linking CXX shared module ..\lib_lightgbm_swig.dll
process_begin: CreateProcess(NULL, cp C:/LightGBM/LightGBM/*.dll com/microsoft/ml/lightgbm/windows/x86_64, ...) failed.
make (e=2): The system cannot find the file specified.
mingw32-make[2]: *** [CMakeFiles\_lightgbm_swig.dir\build.make:89: ../lib_lightgbm_swig.dll] Error 2
mingw32-make[2]: *** Deleting file '../lib_lightgbm_swig.dll'
mingw32-make[1]: *** [CMakeFiles\Makefile2:68: CMakeFiles/_lightgbm_swig.dir/all] Error 2
mingw32-make: *** [Makefile:129: all] Error 2

imatiach-msft · 2018-08-24T16:13:43Z

also, any tips on how to do this

set _lightgbm_swig as default target of make command

looking at swig docs it doesn't mention adding a target anywhere

StrikerRUS · 2018-08-24T16:17:58Z

I think it's the same issue here https://stackoverflow.com/questions/33674973/makefile-error-make-e-2-the-system-cannot-find-the-file-specified

Can you try to specify the full path of cp?

StrikerRUS · 2018-08-24T16:32:13Z

How about to avoid cp with CMake equivalent?

https://stackoverflow.com/a/46660887

imatiach-msft · 2018-08-24T16:34:12Z

FYI this is the error for the add_library call:

CMake Error at C:/Program Files/CMake/share/cmake-3.11/Modules/UseSWIG.cmake:323 (add_library):
  add_library cannot create target "_lightgbm_swig" because another target
  with the same name already exists.  The existing target is a static library
  created in source directory "C:/LightGBM/LightGBM".  See documentation for
  policy CMP0002 for more details.
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.11/Modules/UseSWIG.cmake:273 (swig_add_library)
  CMakeLists.txt:179 (swig_add_module)

StrikerRUS · 2018-08-24T16:37:07Z

Latest CMake https://cmake.org/cmake/help/v3.12/module/UseSWIG.html

Note The variable SWIG_MODULE__REAL_NAME will be set to the name of the swig module target library. This variable is useless if variable UseSWIG_TARGET_NAME_PREFERENCE is set to STANDARD.

StrikerRUS · 2018-08-24T16:40:12Z

Stupid proposal 😄 , but maybe just _lightgbm_swig -> _lightgbm?
https://github.com/Microsoft/LightGBM/blob/dcf9ad2eb9c62dfe347cd249648459500df9d6e6/CMakeLists.txt#L171

StrikerRUS · 2018-08-24T16:46:46Z

In addition to #1599 (comment) here is another way to copy file: https://stackoverflow.com/questions/24311402/copy-all-files-with-given-extension-to-output-directory-using-cmake

imatiach-msft · 2018-08-24T16:47:25Z

I got this error when changing _lightgbm_swig -> _lightgbm:

CMake Error at C:/Program Files/CMake/share/cmake-3.11/Modules/UseSWIG.cmake:323 (add_library):
  add_library cannot create target "_lightgbm" because another target with
  the same name already exists.  The existing target is a shared library
  created in source directory "C:/LightGBM/LightGBM".  See documentation for
  policy CMP0002 for more details.
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.11/Modules/UseSWIG.cmake:273 (swig_add_library)
  CMakeLists.txt:178 (swig_add_module)


CMake Error: File C:/LightGBM/LightGBM/*.dll does not exist.
CMake Error at CMakeLists.txt:187 (configure_file):
  configure_file Problem configuring file


-- Configuring incomplete, errors occurred!
See also "C:/LightGBM/LightGBM/build/CMakeFiles/CMakeOutput.log".

with the following code:

if(USE_SWIG)
  set_property(SOURCE swig/lightgbmlib.i PROPERTY CPLUSPLUS ON)
  LIST(APPEND swig_options -package com.microsoft.ml.lightgbm)
  set_property(SOURCE swig/lightgbmlib.i PROPERTY SWIG_FLAGS "${swig_options}")
  swig_add_module(_lightgbm java swig/lightgbmlib.i)
  if(MSVC)
    set_target_properties(_lightgbm_swig PROPERTIES OUTPUT_NAME "lib_lightgbm_swig")
  endif(MSVC)
  if(WIN32)
    if(MINGW OR CYGWIN)
        add_custom_command(TARGET _lightgbm POST_BUILD
	        COMMAND "${Java_JAVAC_EXECUTABLE}" -d . java/*.java
	        COMMAND "${Java_JAR_EXECUTABLE}" -cf lightgbmlib.jar com)
		configure_file("${PROJECT_SOURCE_DIR}/*.dll" com/microsoft/ml/lightgbm/windows/x86_64 COPYONLY)
    else()
        add_custom_command(TARGET _lightgbm POST_BUILD
	        COMMAND "${Java_JAVAC_EXECUTABLE}" -d . java/*.java
	        COMMAND cp "${PROJECT_SOURCE_DIR}/Release/*.dll" com/microsoft/ml/lightgbm/windows/x86_64
	        COMMAND "${Java_JAR_EXECUTABLE}" -cf lightgbmlib.jar com)
    endif()
  else()
    add_custom_command(TARGET _lightgbm POST_BUILD
	    COMMAND "${Java_JAVAC_EXECUTABLE}" -d . java/*.java
	    COMMAND cp "${PROJECT_SOURCE_DIR}/*.so" com/microsoft/ml/lightgbm/linux/x86_64
	    COMMAND "${Java_JAR_EXECUTABLE}" -cf lightgbmlib.jar com)
  endif()
endif(USE_SWIG)

imatiach-msft · 2018-08-24T16:49:12Z

the configure_file command doesn't seem to work because the cp needs to be done as part of the POST_BUILD task, hmmm

imatiach-msft · 2018-08-24T16:50:07Z

I wonder if the fact that I have bash.exe in C:\Windows\System32 is messing mingw up (bash on windows)

imatiach-msft · 2018-08-25T03:28:56Z

@StrikerRUS how did you build them? I had the lib_ in front:

mkdir build
cd build
cmake -G "MinGW Makefiles" -DUSE_SWIG=ON ..
mingw32-make.exe -j4

did you have this fix included:

if(MSVC) 
    set_target_properties(_lightgbm_swig PROPERTIES OUTPUT_NAME "lib_lightgbm_swig") 
  endif(MSVC)

StrikerRUS · 2018-08-25T08:38:28Z

did you have this fix included:

Yep. But it's for Visual Studio case and we're speaking about MinGW now.

BTW, I have no idea why it works here for WinGW without specifying SWIG target

mingw32-make.exe -j4

At Travis CI service this command didn't build SWIG part, only ordinal LightGBM dll. After changing to make _lightgbm_swig -j4 everything was OK.

StrikerRUS · 2018-08-25T09:26:13Z

I don't know, maybe something wrong with my environment, but I think it's better to prevent build failures for other users who may have the same problems:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index da249c2..cab1a2a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -177,15 +177,13 @@ if(USE_SWIG)
   set_property(SOURCE swig/lightgbmlib.i PROPERTY SWIG_FLAGS "${swig_options}")
   swig_add_module(_lightgbm_swig java swig/lightgbmlib.i)
   swig_link_libraries(_lightgbm_swig _lightgbm)
-  if(MSVC)
-    set_target_properties(_lightgbm_swig PROPERTIES OUTPUT_NAME "lib_lightgbm_swig")
-  endif(MSVC)
   if(WIN32)
+    set_target_properties(_lightgbm_swig PROPERTIES OUTPUT_NAME "lib_lightgbm_swig")
     if(MINGW OR CYGWIN)

What do you think?

StrikerRUS · 2018-08-25T10:46:18Z

I've found the reason of the lib prefix! 🌟
https://gitlab.kitware.com/cmake/cmake/merge_requests/1871/diffs

The :module:UseSWIG module :command:swig_add_library command
(and legacy swig_add_module command) now set the prefix of
Java modules to "" for MINGW, MSYS, and CYGWIN environments.

Now this change seems to be reasonable (and even required).

Due to the latest JAVA environment I had to install latest CMake (3.12). That's why we have different behavior with you.

imatiach-msft · 2018-08-25T17:41:26Z

you're change seems reasonable, I'll update the PR, good find!

imatiach-msft · 2018-08-25T17:51:00Z

"At Travis CI service this command didn't build SWIG part, only ordinal LightGBM dll. After changing to make _lightgbm_swig -j4 everything was OK."
Sorry, maybe I am misunderstanding, but did the Travis CI server specify the SWIG flag also, eg:
cmake -G "MinGW Makefiles" -DUSE_SWIG=ON ..
and even with that it did not build the lib_lightgbm_swig dll? strange, it works for me.
is this comment resolved by setting the output with the new version of cmake, or is this still an issue that needs to be looked into?

StrikerRUS · 2018-08-25T18:16:47Z

You are right.

cmake -DUSE_SWIG=ON ..  
make

didn't work, but

cmake -DUSE_SWIG=ON ..  
make _lightgbm_swig

worked fine. But it was a month ago at Travis.

I didn't re-checked this and thought that the same situation is with MinGW too. However, yesterday I discovered that

cmake -DUSE_SWIG=ON -G"MinGW Makefiles" ..  
mingw32-make

works OK.

Let me do tests again and I'll back to you with results.
However, it seems to be very minor issue, because it's enough to provide mingw32-make _lightgbm_swig command for users and everything will be OK in 100% cases.

PS. My intuition is that it's CMake version issue again (at Travis it's extremely old).

UPD:
So many confusing commits related to SWIG module target!..

UseSWIG: Do not set PREFIX property for SHARED and STATIC lua libraries
UseSWIG: Fall back to empty PREFIX for unknown languages
UseSWIG: fix prefix library for Java on Windows
UseSWIG: reintroduce legacy target name management
UseSWIG: add policy to manage target naming strategy
...
https://github.com/Kitware/CMake/commits/master/Modules/UseSWIG.cmake
😮

StrikerRUS · 2018-08-25T18:20:10Z

CMakeLists.txt

-    COMMAND "${Java_JAVAC_EXECUTABLE}" -d . java/*.java
-    COMMAND cp "${PROJECT_SOURCE_DIR}/*.so" com/microsoft/ml/lightgbm/linux/x86_64
-    COMMAND "${Java_JAR_EXECUTABLE}" -cf lightgbmlib.jar com)
+  set_target_properties(_lightgbm_swig PROPERTIES OUTPUT_NAME "lib_lightgbm_swig")


Can you please write a comment here, because someone might want to "optimize" this line in the future.

did my comment make sense? what were you specifically looking for in the comment?

Your comment is pretty good! Many thanks!

StrikerRUS · 2018-08-25T23:21:07Z

I'm so sorry, @imatiach-msft !

I've found that a month ago I ran tests with make _lightgbm, not just make command.

I've re-tested at Travis and everything is OK with default targets. Sorry again.

StrikerRUS · 2018-08-25T23:29:33Z

Unfortunately, I've found a new bug. 😢
Please take a look at logs:
https://travis-ci.org/Microsoft/LightGBM/jobs/420619579#L1749

CMake 3.9.2 on Ubuntu produces liblib_lightgbm_swig.so.
Taking into account changing default behavior from version to version, I think that we cannot rely only on

set_target_properties(_lightgbm_swig PROPERTIES OUTPUT_NAME "lib_lightgbm_swig")

and need explicitly disable prefix somehow...

imatiach-msft · 2018-08-26T05:34:21Z

maybe only execute that line on windows?

imatiach-msft · 2018-08-26T05:48:41Z

hmm, I updated the PR, is there a particular corner case that I am missing?

StrikerRUS · 2018-08-26T11:34:54Z

I'm afraid that it'll produce liblib_lightgbm_swig.so name with old CMake version and MinGW. Can you please check it with your CMake 3.11?

StrikerRUS · 2018-08-26T11:45:47Z

What do you think about the following "hack", which will hardcode the name and supposed to work for all CMake versions and platforms?
Inspired by this Kitware/CMake@51b6426#diff-276855d5d58f8f4c0de1b0132c887f05

<for all platforms>
set_target_properties(_lightgbm_swig PROPERTIES PREFIX "")
set_target_properties(_lightgbm_swig PROPERTIES OUTPUT_NAME "lib_lightgbm_swig")

(Not sure about the order of these commands)

imatiach-msft · 2018-08-26T23:16:19Z

"old CMake version and MinGW"
I don't think we should worry about older versions, the solution is usually to upgrade to latest stable version (or, we might be able to add version-specific code, but I think that is too much for the SWIG feature).
I like this idea, will update the code. If it works for older versions of CMake that's a great bonus.

StrikerRUS · 2018-08-27T01:03:42Z

Also, it'll protect us from any future changes in prefix policy. 💪

imatiach-msft · 2018-08-27T01:31:00Z

this works great! I verified this on:
windows build without mingw
windows build with mingw
linux (ubuntu 16.04) build
in all cases the swig [so/dll] was built and placed in the correct directory :)

StrikerRUS · 2018-08-27T18:33:34Z

Let me enhance the list:

Windows with MinGW (CMake 3.12, SWIG 3.0.12);
Linux (Ubuntu 14.04) (CMake 3.9.2, SWIG 2.0.11)

StrikerRUS

Thank you very much, @imatiach-msft !

ping @guolinke

guolinke · 2018-08-28T01:55:59Z

Thank you very much !

daniloascione · 2018-08-29T07:30:02Z

Thank you for this one. I could help here to test/validate on Mac.

imatiach-msft force-pushed the ilmat/add-swig-win branch from 7d76a58 to 8a8fe38 Compare August 25, 2018 17:45

StrikerRUS reviewed Aug 25, 2018

View reviewed changes

imatiach-msft force-pushed the ilmat/add-swig-win branch from bd8695e to 9636810 Compare August 27, 2018 01:26

Added LightGBM JAVA SWIG wrapper support for windows

b41df0f

imatiach-msft force-pushed the ilmat/add-swig-win branch from 9636810 to b41df0f Compare August 27, 2018 02:13

StrikerRUS approved these changes Aug 27, 2018

View reviewed changes

StrikerRUS mentioned this pull request Aug 27, 2018

fix SWIG version -Wstrict-aliasing warnings #1556

Closed

guolinke approved these changes Aug 28, 2018

View reviewed changes

guolinke merged commit aac8e8f into microsoft:master Aug 28, 2018

StrikerRUS mentioned this pull request Aug 28, 2018

[docs] added SWIG version compile guide for Windows and tip about JAVA_HOME #1621

Merged

lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020

Added LightGBM JAVA SWIG wrapper support for windows #1599

Added LightGBM JAVA SWIG wrapper support for windows #1599

Conversation

imatiach-msft commented Aug 22, 2018 • edited

StrikerRUS commented Aug 22, 2018 • edited

imatiach-msft commented Aug 24, 2018

imatiach-msft commented Aug 24, 2018

imatiach-msft commented Aug 24, 2018

imatiach-msft commented Aug 24, 2018

StrikerRUS commented Aug 24, 2018

imatiach-msft commented Aug 24, 2018 • edited

StrikerRUS commented Aug 24, 2018 • edited

imatiach-msft commented Aug 24, 2018

imatiach-msft commented Aug 24, 2018

StrikerRUS commented Aug 24, 2018

imatiach-msft commented Aug 24, 2018 • edited

imatiach-msft commented Aug 24, 2018

StrikerRUS commented Aug 24, 2018

imatiach-msft commented Aug 24, 2018

imatiach-msft commented Aug 24, 2018 • edited

StrikerRUS commented Aug 24, 2018

imatiach-msft commented Aug 24, 2018

StrikerRUS commented Aug 24, 2018

imatiach-msft commented Aug 24, 2018

imatiach-msft commented Aug 24, 2018 • edited

StrikerRUS commented Aug 24, 2018

StrikerRUS commented Aug 24, 2018

imatiach-msft commented Aug 24, 2018

StrikerRUS commented Aug 24, 2018

StrikerRUS commented Aug 24, 2018

StrikerRUS commented Aug 24, 2018

imatiach-msft commented Aug 24, 2018 • edited

imatiach-msft commented Aug 24, 2018

imatiach-msft commented Aug 24, 2018

imatiach-msft commented Aug 25, 2018 • edited

StrikerRUS commented Aug 25, 2018

StrikerRUS commented Aug 25, 2018 • edited

StrikerRUS commented Aug 25, 2018 • edited

imatiach-msft commented Aug 25, 2018

imatiach-msft commented Aug 25, 2018

StrikerRUS commented Aug 25, 2018 • edited

StrikerRUS Aug 25, 2018

Choose a reason for hiding this comment

imatiach-msft Aug 26, 2018

Choose a reason for hiding this comment

imatiach-msft Aug 26, 2018

Choose a reason for hiding this comment

StrikerRUS Aug 26, 2018

Choose a reason for hiding this comment

StrikerRUS commented Aug 25, 2018 • edited

StrikerRUS commented Aug 25, 2018

imatiach-msft commented Aug 26, 2018

imatiach-msft commented Aug 26, 2018

StrikerRUS commented Aug 26, 2018 • edited

StrikerRUS commented Aug 26, 2018 • edited

imatiach-msft commented Aug 26, 2018

StrikerRUS commented Aug 27, 2018

imatiach-msft commented Aug 27, 2018

StrikerRUS commented Aug 27, 2018

StrikerRUS left a comment

Choose a reason for hiding this comment

guolinke commented Aug 28, 2018

daniloascione commented Aug 29, 2018

imatiach-msft commented Aug 22, 2018 •

edited

StrikerRUS commented Aug 22, 2018 •

edited

imatiach-msft commented Aug 24, 2018 •

edited

StrikerRUS commented Aug 24, 2018 •

edited

imatiach-msft commented Aug 24, 2018 •

edited

imatiach-msft commented Aug 24, 2018 •

edited

imatiach-msft commented Aug 24, 2018 •

edited

imatiach-msft commented Aug 24, 2018 •

edited

imatiach-msft commented Aug 25, 2018 •

edited

StrikerRUS commented Aug 25, 2018 •

edited

StrikerRUS commented Aug 25, 2018 •

edited

StrikerRUS commented Aug 25, 2018 •

edited

StrikerRUS commented Aug 25, 2018 •

edited

StrikerRUS commented Aug 26, 2018 •

edited

StrikerRUS commented Aug 26, 2018 •

edited