Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] docs for lgb.Dataset in R are incomplete #4193

Closed
david-cortes opened this issue Apr 18, 2021 · 6 comments
Closed

[R-package] docs for lgb.Dataset in R are incomplete #4193

david-cortes opened this issue Apr 18, 2021 · 6 comments

Comments

@david-cortes
Copy link
Contributor

In the R package, the function lgb.Dataset has a parameter categorical_feature, with this description:

categorical features

#' @param categorical_feature categorical features

It does not describe what kind of input it needs to be, in contrast to lgb.Dataset.set.categorical.

@jameslamb
Copy link
Collaborator

Thanks for using {lightgbm} and for looking into the documentation.

In this case, the parameter categorical_feature can be either:

  1. A character vector of feature names
  2. A numeric or integer vector of column indices (1-based, so e.g. "3" would mean "the third column")

Are you interested in contributing some improvements to the R package's documentation? If you are, we would be really grateful for the help! If not, then no problem at all and I can update this documentation soon.

@jameslamb jameslamb changed the title Docs for lgb.Dataset in R are incomplete [R-package] docs for lgb.Dataset in R are incomplete Apr 18, 2021
@david-cortes
Copy link
Contributor Author

Thanks but I'll pass on that as I'm not really familiar with it.

BTW I notice it's missing the docs for allowed parameters.

@jameslamb
Copy link
Collaborator

Ok no problem. Can you please clarify what you mean by "allowed parameters"?

@david-cortes
Copy link
Contributor Author

Ok no problem. Can you please clarify what you mean by "allowed parameters"?

Functions lightgbm, lgb.train, lgb.cv, have an argument params which says: List of parameters.

@jameslamb
Copy link
Collaborator

I see, ok. Yes we should be linking to https://lightgbm.readthedocs.io/en/latest/Parameters.html in those places.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants