Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

April 2021 update ready for review and QC #89

Merged
merged 39 commits into from
Apr 1, 2021

Conversation

kylebunting
Copy link
Collaborator

The April 2021 update is ready for review and QC.

- Azure development workload for Visual Studio 2019
- <https://docs.microsoft.com/azure/azure-functions/functions-develop-vs#prerequisites>
- .NET Framework 4.7 runtime (or higher) and .NET Core 3.1
- <https://www.microsoft.com/net/download/windows>
- Office 365 account. If required, you can sign up for an Office 365 trial at:
- <https://portal.office.com/Signup/MainSignup15.aspx?Dap=False&QuoteId=79a957e9-ad59-4d82-b787-a46955934171&ali=1>
- GitHub account. You can create a free account at <https://github.com>.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Github account is listed here as a requirement, but then Task 5 details creating an account. I think Task 5 could just be removed and instead link to the Github account creation docs here.

@timahenning timahenning self-assigned this Mar 31, 2021
@lynnaloo
Copy link

I got a BadRequest error deploying the Logic App via the ARM template, but I couldn't see the cause of the problem. It might be something in my environment, but worth double-checking just in case. I was able to set it up manually and move on.

I don't have any other suggestions/changes.

@joelhulen
Copy link
Contributor

Hello from the 757, @lynnaloo! Thanks for reviewing the MCW update :)

@kylebunting
Copy link
Collaborator Author

@DawnmarieDesJardins, the changes based on the feedback from @lynnaloo above have been incorporated into the pull request. I made a minor modification to the ARM template to fix the issue with the Logic App.

This is ready for QC/merge.

@DawnmarieDesJardins DawnmarieDesJardins merged commit 273d774 into microsoft:master Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants