-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse natvis format specifiers properly #1031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this list here: http://www.sourceware.org/gdb/onlinedocs/gdb/Output-Formats.html
I don't see some of the ones you have on here. Do you have a reference document that specifies some of these?
Thanks for the PR. Can you tell us which debugger version and distros you tried this on so that we can validate the testing matrix? @WardenGnaw TODO: add tests for these format specifiers |
https://docs.microsoft.com/en-us/visualstudio/debugger/format-specifiers-in-cpp
gdb 9/10 on WSL2 Ubuntu 18.04/20.04. |
The problem with https://docs.microsoft.com/en-us/visualstudio/debugger/format-specifiers-in-cpp?view=vs-2019 is that it is specifically for the Visual Studio Debugger ( |
@WardenGnaw Assigning to you. I'm approving it but I'll leave it up to you to determine when to commit this change. |
The reason for adding these is compatibility with natvis type definitions originally written for VS. |
case "sb": | ||
case "s8": | ||
case "s8b": | ||
case "bstr": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bstr
is different and not worth supported as BSTR
is a Windows-only concept.
d444906
to
dc3f237
Compare
Done. |
@WardenGnaw I still don't see it in the changelog. So I guess it hasn't been integrated yet? |
I must have missed this one when updating the change log. |
fixes #4