support debug console auto-completion

[Trass3r]

It basically works but sometimes vscode only offers the history suggestions even though it receives a proper completions response:

{
  "type":"response",
  "request_seq":15,
  "success":true,
  "command":"completions",
  "body":{
    "targets":[
      {
        "label":"`passcount",
        "start":0,
        "length":1
      },
      {
        "label":"`path",
        "start":0,
        "length":1
      },
      {
        "label":"`pipe",
        "start":0,
        "length":1
      },
      {
        "label":"`print",
        "start":0,
        "length":1
      },
......
    ]
  },
  "seq":565
}

May be a vscode bug but I can't see anything in
https://github.com/microsoft/vscode/blob/e0d5fae35ff101b37da0c8bee61551ceeb6a2e1c/src/vs/workbench/contrib/debug/browser/repl.ts#L151-L190

[Trass3r]

ping

[WardenGnaw]

Proof of concept.

I was ignoring it due to this comment. Is this testable in VS Code?

[Trass3r]

I see, yes should still be.

[gregg-miskelly]

If the command doesn't start with ``` or -exec don't you want to not call AutoComplete?

[Trass3r]

Well that's the question. As I said if we talk about the vscode debug console and gdb nobody expects expression completion. If the completion is also used for Watches (spec doesn't talk about that) then that's something else.
And I guess for VS Immediate Window you'd expect expressions.

[gregg-miskelly]

If it doesn't start with ``` or -exec then it is an expression. Since GDB doesn't have expression auto complete, I think we need to just return an empty match list without calling the engine.

[WardenGnaw]

Sorry for talking long to get back to this. We were finalizing getting testing tp be OpenSourced and moving MIEngine to .NET 5.

With these changes we request that any changes to OpenDebugAD7/DAP is also covered in the testing scenario.

Here is a commit with changes for testing AutoComplete: 3a1d8d4

[WardenGnaw]

If you want to merge in my branch dev/waan/completions, it addresses the issues above.

[Trass3r]

@WardenGnaw "First-time contributors need a maintainer to approve running workflows"

[gregg-miskelly]

@WardenGnaw "First-time contributors need a maintainer to approve running workflows"

Done

[WardenGnaw]

Sorry, one more thing to address that is fixed in f23ba3c

Heres a gif of it working:

[Trass3r]

Well my opinion is still that debug console inputs should just be treated as commands in general when you're on Linux. That's what you expect as a gdb user.
But let's just get this thing merged asap.