Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subprocess call for optimizer microservice and minor typos #57

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Fix subprocess call for optimizer microservice and minor typos #57

merged 1 commit into from
Sep 8, 2020

Conversation

theUltraMarine19
Copy link
Contributor

  • Added flag shell=True for optimizer microservice to run from ipython Notebook
  • Modified current_config: {current_cache_config} to current_config: {new_config_values} for optimization experiment
  • Fixed minor typos in Bayesian Optimization Notebook

@ghost
Copy link

ghost commented Sep 5, 2020 •
edited by ghost

CLA assistant check
All CLA requirements met.

bpkroth
bpkroth approved these changes Sep 5, 2020
View reviewed changes
Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theUltraMarine19 theUltraMarine19 mentioned this pull request Sep 5, 2020
Closed
@amueller amueller merged commit 6560640 into microsoft:main Sep 8, 2020
@amueller
Copy link
Contributor

amueller commented Sep 8, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpkroth bpkroth bpkroth approved these changes

@amueller amueller Awaiting requested review from amueller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@theUltraMarine19 @amueller @bpkroth