Fixups and testing for cli config file parsing #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motus
reviewed
Mar 21, 2024
mlos_bench/mlos_bench/launcher.py
Outdated
| {key: val for (key, val) in config.items() if key not in vars(args)}, | ||
| # Include any item from the cli config file that either isn't in the cli | ||
| # args at all or whose cli arg is missing. | ||
| {key: val for (key, val) in config.items() if key not in args_dict or args_dict[key] is None}, |
There was a problem hiding this comment.
Suggested change
| {key: val for (key, val) in config.items() if key not in args_dict or args_dict[key] is None}, | |
| {key: val for (key, val) in config.items() if args_dict.get(key) is None}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further fixups to #717
Some parameters were not being respected from
--config test-cli-config.jsoncfiles.Split out from #720