Log an error if imported in Directory.Build.props #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the MSBuild Update gesture is used, Microsoft.Build.CentralPackageVersions must be included in Directory.Build.targets not Directory.Build.props. This change logs an error so that users will know when they've made this mistake. Fixes microsoft#179
jeffkl
added a commit
to jeffkl/MSBuildSdks
that referenced
this pull request
Dec 2, 2021
…om import pattern. microsoft#322 didn't take into account that if Microsoft.Build.CentralPackageVersions is imported in a custom way. This change now makes sure it was imported after Microsoft.Common.targets Fixes microsoft#324
jeffkl
added a commit
to jeffkl/MSBuildSdks
that referenced
this pull request
Dec 3, 2021
)" This reverts commit af63eab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the MSBuild Update gesture is used, Microsoft.Build.CentralPackageVersions must be included in Directory.Build.targets not Directory.Build.props. This change logs an error so that users will know when they've made this mistake.
Fixes #179