RunVSTest: Allow overriding the ToolExe/ToolPath #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfederm
force-pushed
the
vstest-tool-override
branch
from
aa0dbc8
to
fceb96b
Compare
AndyGerlicher
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ToolTaskhas built-in parameters forToolExe/ToolPathwhich allow callers to override the tool being called. This lights those up for theRunVSTestTaskThere's also a minor change to avoid using an undefined
%VSINSTALLDIR%and instead fallback to looking in thePATH(behavior when returning a filename fromGenerateFullPathToTool).Reference to relevant
ToolTasklogic: https://github.com/dotnet/msbuild/blob/7ca3c98fad986066bbf2802c863236b4a0f4e34a/src/Utilities/ToolTask.cs#L503-L566