Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional assembly for net40 #17

Closed
wants to merge 1 commit into from
Closed

Conversation

maxwellb
Copy link

Support a net40 build. Linked files for build, rewrote a blank Events class. Let me know if that would cause issues with serialization or anything - but it looked to be just internal.

@doubleyewdee
Copy link
Contributor

Thanks Max,

I'm going to talk to Ben about pulling the EventSource stuff out (it needs work on our end though) since we can drive that entirely with events. We have a separate issue for supporting this as a PCL and that's the only thing stopping us at present.

That said, I'd love to encourage folks to move to .NET 4.5+ in general as well. :)

@stakx
Copy link
Contributor

stakx commented Sep 30, 2015

I'd love to encourage folks to move to .NET 4.5+ in general as well.

I think it would be great to achieve this by offering additional benefits instead of by force. Updating a large project to .NET 4.5+ because a (rather important) infrastructural component requires it often isn't feasible.

A better way (IMHO) might be to offer an alternative .NET 4 (or even earlier) version that relies on System.Diagnostics.TraceSource instead of ETW, and then point out the disadvantages (e.g. slower performance). People would then be free to choose whether it is worth updating to .NET 4.5 in order to get the benefits.

@khellang khellang mentioned this pull request Dec 1, 2015
@doubleyewdee
Copy link
Contributor

This is resolved by #29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants