Replace [ExpectedException] with Assert.Throws
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As outlined in issue #34, unit tests relying on a `[ExpectedException]` attribute should be rewritten to use `Assert.Throws` instead: * `[ExpectedException]` is too coarse-grained and doesn't allow us to test only the Act stage in Arrange-Act-Assert. `Assert.Throws` does not suffer from this. * `[ExpectedException]` is no longer supported in NUnit version 3. This commit replaces all occurrences of the attribute with the more flexible `Assert.Throws`. In some cases, parts of the `TestDelegate` that belong to the Arrange stage are moved out of it.
|
@stakx, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces all occurrences of the
[ExpectedException]attribute on unit test methods with the more recent and flexibleAssert.Throwssyntax. As outlined in issue #34, this has some benefits: