Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CBT support, require MSBuild 15, support .NET Standard 1.4 #41

Merged
merged 3 commits into from
Apr 6, 2017

Conversation

doubleyewdee
Copy link
Contributor

Fixes:

  • AssemblyVersion not in sync w/ NuGet package version.
  • Adds use of CommonBuildToolset (https://github.io/commonbuildtoolset) for build extensions
  • Migrate to MSBuild 15
  • Target .NET Standard 1.4 in addition to 4.0, 4.5
  • Some code cleanup required by migration

Stuff to look at (code-wise):

  • Changed Dispose check in RecyclableMemoryStream to use long disposed member in order to switch to Interlocked.Read (required for netstandard14)
  • Changed EventSource static writer to be named Writer (avoids overload confusion with new static Write methods in newer versions of EventSource e.g. netstandard14)
  • Alternate (non-override) signature for netstandard14 Close and GetBuffer methods on RecyclableMemoryStream (they are not members of MemoryStream) -- the GetBuffer method is interesting, netstandard users will need to ensure they use RMS and not MS if they need to peel off large buffers for whatever reason.

commit d97eaead71ceab5a38f19a9d1887cfc75bf2ea37
Author: Chip Locke <wd@teleri.net>
Date:   Mon Apr 3 18:23:26 2017 -0700

    unit tests build now yay.

commit b4aa37dcdaf66c514e9f7aebd937fc013456553d
Author: Chip Locke <wd@teleri.net>
Date:   Mon Apr 3 17:24:57 2017 -0700

    get source portion building x-plat
@doubleyewdee doubleyewdee merged commit bc87088 into microsoft:master Apr 6, 2017
@arpit-nagar
Copy link

arpit-nagar commented Apr 18, 2017

As you already added support for netStandard in master.
Can you please publish a nuget package which supports net standard?

@brunoblank
Copy link

I tried the source today (compiled for netstandard 1.6) and TryGetBuffer did return false.
Is the netstandard support complete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants