-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice - left some feedback. I’m on mobile and will take another look tomorrow on my computer. Thank you!!
imo the docs should explicitly state whether memory in the pooled buffers will be initialized or not - if not, calling GetBuffer() is a security risk due to the possibility the buffer will be bigger than the actual content. |
This looks really great so far - thanks @benmwatson |
Co-Authored-By: Steve Ognibene <steve.ognibene@namely.com>
Co-Authored-By: Steve Ognibene <steve.ognibene@namely.com>
Co-Authored-By: Steve Ognibene <steve.ognibene@namely.com>
Co-Authored-By: Steve Ognibene <steve.ognibene@namely.com>
Co-Authored-By: Steve Ognibene <steve.ognibene@namely.com>
Added significant documentation updates in README.md. Also added a diagram and updated the CHANGES.md file with last release.