Merge pull request #2449 from NikCharlebois/FIXES-#2447

Fixes #2447
microsoft · Oct 26, 2022 · 36056f2 · 36056f2
2 parents f9464a2 + 9f4f291
commit 36056f2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,7 +17,9 @@
 * DEPENDENCIES
   * Updated MSCloudLoginAssistant to version 1.0.96;
 * MISC
-  * Add support for ManagedIdentity to the SPo and OD resources.
+  * Add support for ManagedIdentity to the SPO and OD resources.
+  * Fixed and issue with Export and ApplicationSecret where it wasn't properly converting to a PSCredential.
+    * FIXES [#2447](https://github.com/microsoft/Microsoft365DSC/issues/2447)
 
 # 1.22.1019.1
 

diff --git a/Modules/Microsoft365DSC/Modules/M365DSCReverse.psm1 b/Modules/Microsoft365DSC/Modules/M365DSCReverse.psm1
@@ -234,10 +234,12 @@ function Start-M365DSCConfigurationExtract
                 $AuthMethods -contains 'CertificatePath' -or `
                 $AuthMethods -contains 'ApplicationWithSecret')
         {
+            [SecureString]$secStringPassword = ConvertTo-SecureString $ApplicationSecret -AsPlainText -Force
+            [PSCredential]$AppSecretAsPSCredential = New-Object System.Management.Automation.PSCredential ('ApplicationSecret', $secStringPassword)
             $organization = Get-M365DSCTenantDomain -ApplicationId $ApplicationId `
                 -TenantId $TenantId `
                 -CertificateThumbprint $CertificateThumbprint `
-                -ApplicationSecret $ApplicationSecret `
+                -ApplicationSecret $AppSecretAsPSCredential `
                 -CertificatePath $CertificatePath
         }
         elseif ($AuthMethods -Contains 'Credentials')

diff --git a/Modules/Microsoft365DSC/Modules/M365DSCUtil.psm1 b/Modules/Microsoft365DSC/Modules/M365DSCUtil.psm1
@@ -1376,7 +1376,7 @@ function Get-M365DSCTenantDomain
         $TenantId,
 
         [Parameter(ParameterSetName = 'AppId')]
-        [System.String]
+        [System.Management.Automation.PSCredential]
         $ApplicationSecret,
 
         [Parameter(ParameterSetName = 'AppId')]