[SPOTenantCdnEnabled] False does not provide any export results

[ykuijs]

Details of the scenario you tried and the problem that is occurring

When this setting is disabled, the export does not include the resource because Enabled=False is filtered out here:

Microsoft365DSC/Modules/Microsoft365DSC/DSCResources/MSFT_SPOTenantCdnEnabled/MSFT_SPOTenantCdnEnabled.psm1

Lines 372 to 384 in d3e1ad0

	if ($Results.Enable -eq $True)
	{
	$Results = Update-M365DSCExportAuthenticationResults -ConnectionMode $ConnectionMode `
	-Results $Results
	$currentDSCBlock = Get-M365DSCExportContentForResource -ResourceName $ResourceName `
	-ConnectionMode $ConnectionMode `
	-ModulePath $PSScriptRoot `
	-Results $Results `
	-Credential $Credential
	$dscContent += $currentDSCBlock
	Save-M365DSCPartialExport -Content $currentDSCBlock `
	-FileName $Global:PartialExportFileName
	}

But this can be False because of either the Get-TargetResource returned False or nothing (because Get-PnPTenantCdnEnabled threw an exception.

Question now is: Should the resource be filtered when the setting is False?

Verbose logs showing the problem

Suggested solution to the issue

The DSC configuration that is used to reproduce the issue (as detailed as possible)

# insert configuration here

The operating system the target node is running

Version of the DSC module that was used ('dev' if using current dev branch)

dev

[andikrueger]

I would add this information to the export of the resource. This could cause errors in export/import scenarios across various "stages". I someone would have enable the setting, it would not be disabled in other cases. Disabled is the default state, isn't it?

[ykuijs]

I believe it is indeed.

Right now the code returns an empty string when an exception occurs:

Microsoft365DSC/Modules/Microsoft365DSC/DSCResources/MSFT_SPOTenantCdnEnabled/MSFT_SPOTenantCdnEnabled.psm1

Line 118 in d3e1ad0

return ''

This is the Export code to filter the resource.

Maybe it would be better to return Ensure=Absent and filter on the Ensure instead of the Enabled parameter.