Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds two new Security and Compliance Resources for Supervisory Reviews #125

Merged
merged 13 commits into from
Jun 26, 2019
Merged

Adds two new Security and Compliance Resources for Supervisory Reviews #125

merged 13 commits into from
Jun 26, 2019

Conversation

NikCharlebois
Copy link
Collaborator

Pull Request (PR) description

Adds:

  • SCSupervisoryReviewPolicy
  • SCSupervisoryReviewRule

This Pull Request (PR) fixes the following issues

#123 #122

@codecov-io
Copy link

codecov-io commented Jun 21, 2019

Codecov Report

Merging #125 into Dev will increase coverage by 0.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              Dev     #125     +/-   ##
=========================================
+ Coverage   90.31%   90.71%   +0.4%     
=========================================
  Files          39       41      +2     
  Lines        3262     3381    +119     
  Branches       13       13             
=========================================
+ Hits         2946     3067    +121     
+ Misses        303      301      -2     
  Partials       13       13
Impacted Files Coverage Δ
...visoryReviewRule/MSFT_SCSupervisoryReviewRule.psm1 100% <100%> (ø)
...ryReviewPolicy/MSFT_SCSupervisoryReviewPolicy.psm1 100% <100%> (ø)
...liancePolicy/MSFT_SCRetentionCompliancePolicy.psm1 100% <0%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cefb97...1af4181. Read the comment docs.

@NikCharlebois
Copy link
Collaborator Author

Not quite sure why the test fails when the string is on 2 lines. It works ok when running test harness on-premises.

@ykuijs
Copy link
Member

ykuijs commented Jun 24, 2019

When using throw and multiple lines, don't you have to use parentheses??

                { Set-TargetResource @testParams } | Should throw ("The SCSupervisoryReviewRule resource doesn't not support deleting Rules. " + `
                "Instead try removing the associated policy, or modifying the existing rule.")

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another attempt: GitHub doesn't automatically add comments to the review.......

@NikCharlebois
Copy link
Collaborator Author

@ykuijs Ready for final round of review

@NikCharlebois NikCharlebois merged commit fff0aff into microsoft:Dev Jun 26, 2019
This was referenced Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants