-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds two new Security and Compliance Resources for Supervisory Reviews #125
Conversation
Codecov Report
@@ Coverage Diff @@
## Dev #125 +/- ##
=========================================
+ Coverage 90.31% 90.71% +0.4%
=========================================
Files 39 41 +2
Lines 3262 3381 +119
Branches 13 13
=========================================
+ Hits 2946 3067 +121
+ Misses 303 301 -2
Partials 13 13
Continue to review full report at Codecov.
|
Not quite sure why the test fails when the string is on 2 lines. It works ok when running test harness on-premises. |
When using throw and multiple lines, don't you have to use parentheses?? { Set-TargetResource @testParams } | Should throw ("The SCSupervisoryReviewRule resource doesn't not support deleting Rules. " + `
"Instead try removing the associated policy, or modifying the existing rule.") |
...Office365DSC/DSCResources/MSFT_SCSupervisoryReviewPolicy/MSFT_SCSupervisoryReviewPolicy.psm1
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another attempt: GitHub doesn't automatically add comments to the review.......
Tests/Unit/Office365DSC/Office365DSC.SCSupervisoryReviewRule.Tests.ps1
Outdated
Show resolved
Hide resolved
...fice365DSC/DSCResources/MSFT_SCSupervisoryReviewRule/MSFT_SCSupervisoryReviewRule.schema.mof
Show resolved
Hide resolved
...fice365DSC/DSCResources/MSFT_SCSupervisoryReviewRule/MSFT_SCSupervisoryReviewRule.schema.mof
Show resolved
Hide resolved
...les/Office365DSC/DSCResources/MSFT_SCSupervisoryReviewRule/MSFT_SCSupervisoryReviewRule.psm1
Show resolved
Hide resolved
...365DSC/DSCResources/MSFT_SCSupervisoryReviewPolicy/MSFT_SCSupervisoryReviewPolicy.schema.mof
Show resolved
Hide resolved
...Office365DSC/DSCResources/MSFT_SCSupervisoryReviewPolicy/MSFT_SCSupervisoryReviewPolicy.psm1
Outdated
Show resolved
Hide resolved
@ykuijs Ready for final round of review |
Pull Request (PR) description
Adds:
This Pull Request (PR) fixes the following issues
#123 #122