EXOSafeLinksPolicy: Added missing properties CustomNotificationText, EnableOrganizationBranding, UseTranslatedNotificationText #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpiederiet
force-pushed
the
Feature-EXOSafeLinksPolicy-AddMissingProperties
branch
from
6ea2125
to
2d2c41a
Compare
Properties: CustomNotificationText, EnableOrganizationBranding, UseTranslatedNotificationText
mpiederiet
force-pushed
the
Feature-EXOSafeLinksPolicy-AddMissingProperties
branch
from
2d2c41a
to
72b1cca
Compare
Stubs should be fixed in Microsoft365.psm1 which is autogenerated...
|
@NikCharlebois this commit broke all Intune unit tests Can you please fix them so my PR can pass? Unit tests for EXOSafeLinksPolicy are successful. BTW: I noticed some duplicate functions between generic.psm1 and microsoft365.psm1. I commented most of them. Had to uncomment 2 of them (Set-AzureADDirectorySetting and New-AzureADDirectorySetting) because the function definition in Microsoft365.psm1 made the unit tests fail. I guess the Stub generating module needs to be modified to generate the parameter type for $DirectorySetting correctly? |
Stubs should be fixed in Microsoft365.psm1 which is autogenerated...
…ps://github.com/mpiederiet/Microsoft365DSC into Feature-EXOSafeLinksPolicy-AddMissingProperties
NikCharlebois
approved these changes
Sep 22, 2021
mpiederiet
deleted the
Feature-EXOSafeLinksPolicy-AddMissingProperties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
EXOSafeLinksPolicy: Added missing properties CustomNotificationText, EnableOrganizationBranding, UseTranslatedNotificationText
This Pull Request (PR) fixes the following issues
None