Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed ApplicationSecret variable from string to PSCredential in functions Start-M365DSCConfigurationExtract, Export-M365DSCConfiguration, and Get-M365DSCTenantDomain. Removed line converting the string to a pscredential as it is no longer required, added a line to convert back to string for final output
Pull Request (PR) description
Since The updates to require ApplicationSecret to be in the form of a PSCredential I have had errors when exporting previous configurations.
I think the cause is a few functions which are still expecting ApplicationSecret to be passed as a string. I've amended these functions to use the PSCredential. There are also a couple of changes where the new type needs to be accounted for. I've tested it exporting the Intune workload and the IntuneAppProtectionPolicyAndroid component with no errors,
I believe All the configurations were updated at the same time to require the ApplicationSecret to be a PSCredential but I haven't tested any other configurations
This Pull Request (PR) fixes the following issues
Fixes #2423