Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntuneDeviceConfigurationCustomPolicyWindows10: Change permissions for reading to DeviceManagementConfiguration.ReadWrite.All #4661

Open
wants to merge 7 commits into
base: Dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,15 @@
FIXES [#4283](https://github.com/microsoft/Microsoft365DSC/issues/4283)
* IntuneDeviceConfigurationCustomPolicyWindows10
* Fixed an issue where the payload of xml files was not encoded as base64.
* Change app and delegated permissions for reading to
DeviceManagementConfiguration.ReadWrite.All to cope with
getOmaSettingPlainTextValue which is only working if RW is granted
FIXES [#4412](https://github.com/microsoft/Microsoft365DSC/issues/4412)
* IntuneDeviceConfigurationDefenderForEndpointOnboardingPolicyWindows10
* Fixed a creation and update issue when the exported policy contains a
* Fixed a creation and update issue when the exported policy contains a
onboarding blob and the tenant is connected to Defender for Endpoint Service.
* M365DSCUtil
* Fixed an issue where one could not pass empty arrays to the
* Fixed an issue where one could not pass empty arrays to the
`Compare-PSCustomObjectArrays` function.
* DEPENDENCIES
* Updated Microsoft.Graph to version 2.18.0.
Expand All @@ -36,7 +40,7 @@
* Fixed an issue where the update policy setting was not handled properly.
* IntuneDeviceConfigurationWiredNetworkPolicyWindows10
* Added functionality for specifying the certificates with a display name since their
ids in the blueprint might be from a different source tenant.
ids in the blueprint might be from a different source tenant.
FIXES [#4582](https://github.com/microsoft/Microsoft365DSC/issues/4582)
* MISC
* Added support for AccessTokens in EXO resources.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"name": "Group.Read.All"
},
{
"name": "DeviceManagementConfiguration.Read.All"
"name": "DeviceManagementConfiguration.ReadWrite.All"
}
],
"update": [
Expand All @@ -24,7 +24,7 @@
"name": "Group.Read.All"
},
{
"name": "DeviceManagementConfiguration.Read.All"
"name": "DeviceManagementConfiguration.ReadWrite.All"
}
],
"update": [
Expand Down
7 changes: 7 additions & 0 deletions Tests/QA/Microsoft365DSC.SettingsJson.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,13 @@ Describe -Name 'Successfully validate all used permissions in Settings.json file
)
}

if ($settings.ResourceName -eq 'IntuneDeviceConfigurationCustomPolicyWindows10')
{
$allowedPermissions = @(
'DeviceManagementConfiguration.ReadWrite.All'
)
}

foreach ($permission in $settings.permissions.graph.application.read)
{
$ObjectGuid = [System.Guid]::empty
Expand Down