-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CanvasShadow & UnityUI sample scenes #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, a huge improvement to these samples. Thank you! Added some commends below and inline comments.
Could you reduce the size of the button textures (and make them a power of two). Just to keep our package size down.
Could you also make the lightbulb texture smaller (looks like the panda should be too :D)?
com.microsoft.mrtk.graphicstools.unity/Samples~/Experimental/CanvasShadow/CanvasShadow.unity
Show resolved
Hide resolved
...rtk.graphicstools.unity/Samples~/Experimental/CanvasShadow/Prefabs/DescriptionPanel 1.prefab
Show resolved
Hide resolved
com.microsoft.mrtk.graphicstools.unity/Samples~/UnityUI/Scripts/SliderLight.cs
Show resolved
Hide resolved
com.microsoft.mrtk.graphicstools.unity/Samples~/UnityUI/Scripts/SliderFilament.cs
Show resolved
Hide resolved
com.microsoft.mrtk.graphicstools.unity/Samples~/UnityUI/Scripts/ButtonRed.cs
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.graphicstools.unity/Samples~/UnityUI/Scripts/CursorController.cs
Outdated
Show resolved
Hide resolved
…s/SliderFilament.cs Co-authored-by: Cameron <thmicka@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect!
Overview
The CanvasShadow and UnityUI sample scenes have been updated by adding descriptive texts, 3D models and button/slider functionality in order to enhance the scenes' instructiveness.
Changes
CanvasShadow
UnityUI
Verification