Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CanvasShadow & UnityUI sample scenes #148

Merged
merged 19 commits into from
Jan 25, 2023
Merged

Conversation

Species521
Copy link
Collaborator

Overview

The CanvasShadow and UnityUI sample scenes have been updated by adding descriptive texts, 3D models and button/slider functionality in order to enhance the scenes' instructiveness.

Changes

CanvasShadow

  • the number of shadow examples have been increased to visualize the full spectrum of customizations
  • plain button plates have been replaced with textures in order to show that this is an option
  • descriptive text panel was added
  • top row buttons are clickable

CanvasShadow_click_01

UnityUI

  • a textured tumbling 3D model of a lightbulb has been added
  • the slider has been hooked to the lightbulb's glass & filament materials in order to control the bulb's brightness
  • the three buttons below have been mapped to the lightbulb material's color value in order to switch light colors

UnityUI_lightbulb_1

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.

If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

Copy link
Member

@Cameron-Micka Cameron-Micka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, a huge improvement to these samples. Thank you! Added some commends below and inline comments.

Could you reduce the size of the button textures (and make them a power of two). Just to keep our package size down.

image

Could you also make the lightbulb texture smaller (looks like the panda should be too :D)?
image

Copy link
Member

@Cameron-Micka Cameron-Micka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates! Could you make these last two changes, then this is ready to merge.

  1. Can you revert these two files?
    image

  2. Could you duplicate this backplate material from another sample and put it in this sample so it doesn't appear missing when imported in isolation?
    image

Copy link
Member

@Cameron-Micka Cameron-Micka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

@Cameron-Micka Cameron-Micka merged commit 39ab914 into microsoft:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants