add normalMapSacle to MRGTStandardShader #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cameron-Micka
requested changes
Jul 18, 2022
com.microsoft.mrtk.graphicstools.unity/Editor/ShaderGUIs/StandardShaderGUI.cs
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.graphicstools.unity/Editor/ShaderGUIs/StandardShaderGUI.cs
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.graphicstools.unity/Editor/ShaderGUIs/StandardShaderGUI.cs
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.graphicstools.unity/Runtime/Shaders/GraphicsToolsStandardInput.hlsl
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.graphicstools.unity/Runtime/Shaders/GraphicsToolsStandardProgram.hlsl
Outdated
Show resolved
Hide resolved
|
@Cameron-Micka I did not know this function and still need to learn more about it. I have made some other modifications based on the other fb's I received. |
Cameron-Micka
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The _NormalMapScale parameter, which was unused and dead from the MRGStandardShader parameters, can now be used to change the intensity of the normal map.
Changes
fix #77
・StandardShaderGUI
normalMapScale is now displayed on the inspector.
・GraphicsToolsStandardProgram
Changed to multiply WorldNormal by _NormalMapScale value after normal map packing is complete.
Verification
I have confirmed that I can change the intensity of the normal map both in normal and when using TriplanerMapping.