New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable cancelling localization sessions #247
Enable cancelling localization sessions #247
Conversation
…ectatorView into cancelSessions
...sets/SpatialAlignment.ASA/Scripts/SpatialAlignment/SpatialAnchorsAndroidCoordinateService.cs
Outdated
Show resolved
Hide resolved
...nity/Assets/SpatialAlignment.ASA/Scripts/SpatialAlignment/SpatialAnchorsCoordinateService.cs
Outdated
Show resolved
Hide resolved
...tatorView.Unity/Assets/SpatialAlignment.ASA/Scripts/SpectatorView/SpatialAnchorsLocalizer.cs
Show resolved
Hide resolved
.../SpectatorView/Scripts/SpatialAlignment/MarkerVisual/MarkerVisualDetectorSpatialLocalizer.cs
Outdated
Show resolved
Hide resolved
...orView.Unity/Assets/SpectatorView/Scripts/SpatialAlignment/SpatialCoordinateSystemManager.cs
Outdated
Show resolved
Hide resolved
...ity/Assets/SpectatorView/Scripts/SpatialAlignment/WorldAnchor/WorldAnchorSpatialLocalizer.cs
Outdated
Show resolved
Hide resolved
...sets/SpectatorView/Scripts/SpatialAlignment/PhysicalMarker/MarkerDetectorSpatialLocalizer.cs
Outdated
Show resolved
Hide resolved
...ctatorView.Unity/Assets/SpectatorView/Scripts/SpatialAlignment/SpatialLocalizationSession.cs
Outdated
Show resolved
Hide resolved
...ew.Unity/Assets/SpectatorView/Scripts/SpatialAlignment/SpatialCoordinateSystemParticipant.cs
Outdated
Show resolved
Hide resolved
...orView.Unity/Assets/SpectatorView/Scripts/SpatialAlignment/SpatialCoordinateSystemManager.cs
Outdated
Show resolved
Hide resolved
src/SpectatorView.Unity/Assets/SpatialAlignment/Scripts/Utilities/Extensions.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...orView.Unity/Assets/SpectatorView/Scripts/SpatialAlignment/SpatialCoordinateSystemManager.cs
Outdated
Show resolved
Hide resolved
...nity/Assets/SpatialAlignment.ASA/Scripts/SpatialAlignment/SpatialAnchorsCoordinateService.cs
Outdated
Show resolved
Hide resolved
private ITrackingObserver trackingObserver = null; | ||
|
||
private readonly object localizationLock = new object(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to prefer a separate lock object? If this is only protecting currentLocalizationSession, would we lock that object directly instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
locking on a null object throws exceptions. Since we want to populate currentLocalizationSession within the lock, it seems safer to lock on a separate, non-null object.
This review addresses: #242
In this review:
Breaking Change Details:
Notes:
This review introduces breaking changes to ISpatialLocalizationSession. Contributors felt there was a need to be able to cancel sessions, which led to this change.
Migration Instructions: