Skip to content
This repository has been archived by the owner on Mar 22, 2022. It is now read-only.

Import/Integration in Unity comes with missing namespace errors #168

Closed
sesd777 opened this issue Jan 16, 2020 · 3 comments
Closed

Import/Integration in Unity comes with missing namespace errors #168

sesd777 opened this issue Jan 16, 2020 · 3 comments
Labels
invalid User error or by design

Comments

@sesd777
Copy link

sesd777 commented Jan 16, 2020

Hi, I'm trying to integrate WebRTC for MR into a new Unity project as documented here.
After following the steps I end up with a non working project.

Im using the lastest Unity 2018.3.X (2018.3.14f1)

The steps i did in short:

  • created new unity project and closed Unity

  • cloned this repo (master)

  • inside this repo I copied from: libs/Microsoft.MixedReality.WebRTC.Unity/Assets/
    the Microsoft.MixedReality.WebRTC.Unity folder,
    the Microsoft.MixedReality.WebRTC.Unity.Editor folder
    and the Plugins folder
    and pasted them in the Assets/ folder of my unity project.

  • then downloaded the nuget packages (1.0.2) and copied the native DLLs aswell as the C# Library as explained in the documentation's tables

  • opened Unity and found this:
    unity errors

I haven't imported any MR toolkit or packages of any kind.

My goal is to build the project and deploy the solution to HoloLens 1 later.

@djee-ms
Copy link
Member

djee-ms commented Jan 16, 2020

Yes @sesd777 I believe you did the same mistake as #166, that is you cannot mix the NuGet packages (built from release/1.0) with the Unity source code of master, which contains API breaking changes and is in essence the code for the future 2.0 release. You either want to copy the 2 folders you copied but taken from the release/1.0 branch, to get the latest stable version of the project, or you want to recompile Microsoft.MixedReality.WebRTC.Native.dll and Microsoft.MixedReality.WebRTC.dll from the provided Visual Studio solution using the master branch, to get the latest features. But there is currently no NuGet package of MixedReality-WebRTC corresponding to the master branch (this is by design).

djee-ms added a commit that referenced this issue Jan 16, 2020
- NuGet packages are built from release branches only, and are not
guaranteed to be compatible with the code on the master branch.
- C++ NuGet packages are missing some headers, and require cloning this
repository.

Bugs: #123, #166, #168
@sesd777
Copy link
Author

sesd777 commented Jan 17, 2020

Yes @sesd777 I believe you did the same mistake as #166, that is you cannot mix the NuGet packages (built from release/1.0) with the Unity source code of master, which contains API breaking changes and is in essence the code for the future 2.0 release. You either want to copy the 2 folders you copied but taken from the release/1.0 branch, to get the latest stable version of the project, or you want to recompile Microsoft.MixedReality.WebRTC.Native.dll and Microsoft.MixedReality.WebRTC.dll from the provided Visual Studio solution using the master branch, to get the latest features. But there is currently no NuGet package of MixedReality-WebRTC corresponding to the master branch (this is by design).

yep, that helped. Ty for clarifying

@sesd777 sesd777 closed this as completed Jan 17, 2020
@djee-ms
Copy link
Member

djee-ms commented Jan 17, 2020

Sorry that caused confusion. I added a note on the README to clarify.

@djee-ms djee-ms added the invalid User error or by design label Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid User error or by design
Projects
None yet
Development

No branches or pull requests

2 participants