This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
Merge latest changes from dev #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the user to force a specific audio or video codec by tweaking the SDP offer message to remove other codecs. This is a workaround for the fact codec selection is not exposed in the core WebRTC API.
When compiling UWP wrapper projects individually, the output libs are places in a different folder than when compiled from the Visual Studio solution of WebRTC UWP SDK. Add this alternate folder so that Microsoft.MixedReality.WebRTC.Native.UWP can find the libs it needs to link.
This allows e.g. starting the local video feed after the connection is already established, and by extension stopping and starting it again.
This prevents creating unusable data channels.
Restore support for data channels
Ensure that the SCTP negotiating is only preventing `AddDataChannelAsync` after the connection started, and not before, which is the only way to effectively ensure it occurs.
Patch libyuv to avoid clang compile Patch libyuv via build.ps1 before building, as a workaround until the code is fixed in the upstream submodule. See #157 on WebRTC UWP project for details.
This reverts commit 7a83908.
This reverts commit e07c292.
This reverts commit ee69bec.
Try to reflect the exact state of the project to date. Opened a few issues on GitHub to track TODOs.
Ensure that all projects output to build/ and bin/ only.
This is a debug-only non-production solution so the event is never fired by design, although a proper signalling solution would invoke it.
Some breaking changes were committed to releases/m71 upstream that change the API of VideoCapturer::create() to take a struct instead of individual arguments.
Pass the existing WebRTC UWP factory in the creation parameters of the video capturer. This seems to work without it too, but is probably best to ensure the existing one is used.
This is to work around #176 on WebRTC UWP. https://github.com/webrtc-uwp/webrtc-uwp-sdk/issues/176
This was referenced Feb 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.