Android support #193

eanders-ms · 2020-02-19T01:46:38Z

Add support for Android platform

New folders below /tools/build contain per-platform scripts to build MR-WebRTC, and to build the core Chromium libwebrtc base library:

/tools/build/libwebrtc: Scripts to build the Chromium base library for a given platform.
/tools/build/android: Contains a Gradle+CMake configuration to build MR-WebRTC for Android/arm64-v8a platform.
In the future possibly add more, even all, platform builds here? iOS build is similar to Android.
Interested to hear what you think of this organization. Happy to change it.

Status

libwebrtc build works for Android, with placeholder codepaths for future platforms. Build artifact for Android is libwebrtc.aar. It is automatically copied to the Unity sample project upon build success.
Android build works, though README instructions are incomplete. Build artifact is Microsoft.MixedReality.WebRTC.Native.aar, and is also copied to the Unity sample project automatically.
In testing, the DLL successfully loads and initializes on Android (Quest).
In a two-client test between Desktop/Editor and Quest, Desktop crashes after receiving the SDP answer.

TODO

Finish adding Android build instructions to READMEs.
Fix: VideoChatDemo crashes on Oculus Quest unless Local Video and Scene Capture are disabled.
Revert: Unsure how to fix this one: The change list shows I changed some things in webrtc-uwp-sdk. I should revert those changes.

eanders-ms · 2020-02-19T02:00:33Z

Updated the PR description (not reflected in email below).

djee-ms

No major issue, looks all good overall, amazing work! 👍

libs/Microsoft.MixedReality.WebRTC.Native/src/pch.h

libs/Microsoft.MixedReality.WebRTC.Native/src/sdp_utils.h

libs/Microsoft.MixedReality.WebRTC.Unity/Assets/Plugins/arm64-v8a.meta

libs/Microsoft.MixedReality.WebRTC.Unity/Packages/manifest.json

libs/Microsoft.MixedReality.WebRTC.Unity/ProjectSettings/ProjectSettings.asset

projects/android/webrtc-native/src/main/cpp/jni_onload.cpp

projects/libwebrtc/.gitignore

projects/libwebrtc/ENV-UNIX.md

projects/libwebrtc/build.sh

projects/libwebrtc/lib.sh

projects/android/gradlew

astaikos316 · 2020-03-09T19:08:30Z

@eanders-ms from what I can see from node-dss and logcat, the quest never sends an answer message and the dss polling stops after an offer from the windows standalone is sent. No errors stand out in logcat when attached to the quest.

djee-ms · 2020-03-09T19:59:26Z

My 2c (didn't try) : network/signaling issues aside, not sending an answer is generally a sign of the offer failing to apply, either because of unsupported options (e.g. unsupported video codec), or because the offer arrives at the wrong time or the answer tries to be created too soon, both of which when the peer connection is in an invalid state (must be in "idle" to transition to "have-remote-offer" when applying the offer, and then be able to transition to "have-local-answer" when creating the answer). Typically as an example the latter fails in C# when forgetting to await the SetRemoteDescriptionAsync() call, and calling CreateAnswer() too soon.

...ty.WebRTC.Unity/Assets/Microsoft.MixedReality.WebRTC.Unity/Scripts/Media/LocalAudioSource.cs

djee-ms · 2020-03-25T21:05:56Z

tools/build/libwebrtc/config.sh

+# Functions
+
+#-----------------------------------------------------------------------------
+function usage() {


I've just spent 4 hours setting up an Ubuntu VM with Hyper-V (╯°□°）╯︵ ┻━┻ and resizing the virtual disk to accommodate the gigantic repository (currently at 37GB total partition size) (╯°□°）╯︵ ┻━┻, to be told by the Google setup script that:

ERROR: The only supported distros are Ubuntu 14.04 LTS (trusty) Ubuntu 16.04 LTS (xenial) Ubuntu 17.10 (artful) Ubuntu 18.04 LTS (bionic) Debian 8 (jessie) or later

Yes, I used Ubuntu 19.10 as suggested by default by Hyper-V. 😡

So I really think we should test ASAP in those scripts, preferably during config.sh:

The user runs a valid distribution (see list above)

The user has at least 40GB of disk space available

The actual check is in webrtc/build/install-build-deps.sh which is outdated on branch-heads/71 compared to recent Ubuntu releases (as linked on master it actually supports eoan 19.10). Ideally we'd grab that file and extract the supported distros from it, but it might be a bit complex to reach it via the chain of dependency (git branch => sub-repo chromium/build => script => grep on supported_codenames).

That is terrible! Yes, we need to verify platform earlier.

I pushed some basic checks as discussed (see d425548). Can you please have a look @eanders-ms? My bash is quite rusty... 😉

tools/build/libwebrtc/lib.sh

djee-ms · 2020-03-26T11:25:36Z

tools/build/android/README.md

+    * Android Studio (https://developer.android.com/studio/index.html). Once installed, use the System Settings/Android SDK dialog to install the following packages:
+        * SDKs 9.0 (Pie), 8.1 (Oreo)
+        * CMake
+        * NDK 16.1.4479499


There's no option to select a version of the NDK as I know. I can only see "NDK (side by side)", which as of today resolves to 21.0.6113669. I think that's OK but I can't remember the details about NDK versions.

Actually that's not even enough, I had to uncheck "Hide obsolete packages", then install "NDK (Obsolete)" version 21.0.6113669, then click "Sync Project with Gradle Files" before I was finally allowed to Build > Make Project.

This section is light on detail, due entirely to the fact that I wasn't sure what the best practice is here. I wanted to provide steps that could be done entirely on the command line and not rely on Android Studio. I haven't gone back and worked out what those steps are yet.

We can polish later. I want to commit to master an experimental support version, then we refine the instructions.

Trying to build in Android Studio and getting this build error. any suggestions?

Build command failed.
Error while executing process /home/astaikos/Android/Sdk/cmake/3.10.2.4988404/bin/cmake with arguments {--build /home/astaikos/eanders/MixedReality-WebRTC/tools/build/android/webrtc-native/.externalNativeBuild/cmake/debug/arm64-v8a --target mrwebrtc}
[1/17] Building CXX object CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/interop/local_video_track_interop.cpp.o
[2/17] Building CXX object CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/data_channel.cpp.o
[3/17] Building CXX object CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/str.cpp.o
[4/17] Building CXX object CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/media/local_video_track.cpp.o
[5/17] Building CXX object CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/mrs_errors.cpp.o
[6/17] Building CXX object CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/audio_frame_observer.cpp.o
[7/17] Building CXX object CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/interop/external_video_track_source_interop.cpp.o
[8/17] Building CXX object CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/interop/peer_connection_interop.cpp.o
[9/17] Building CXX object CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/pch.cpp.o
[10/17] Building CXX object CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/media/external_video_track_source.cpp.o
[11/17] Building CXX object CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/interop/global_factory.cpp.o
[12/17] Building CXX object CMakeFiles/mrwebrtc.dir/jni_onload.cpp.o
[13/17] Building CXX object CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/sdp_utils.cpp.o
[14/17] Building CXX object CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/interop/interop_api.cpp.o
[15/17] Building CXX object CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/peer_connection.cpp.o
[16/17] Building CXX object CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/video_frame_observer.cpp.o
[17/17] Linking CXX shared library /home/astaikos/eanders/MixedReality-WebRTC/tools/build/android/webrtc-native/build/intermediates/cmake/debug/obj/arm64-v8a/libmrwebrtc.so
FAILED: /home/astaikos/eanders/MixedReality-WebRTC/tools/build/android/webrtc-native/build/intermediates/cmake/debug/obj/arm64-v8a/libmrwebrtc.so
: && /home/astaikos/Android/Sdk/ndk/21.0.6113669/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++ --target=aarch64-none-linux-android24 --gcc-toolchain=/home/astaikos/Android/Sdk/ndk/21.0.6113669/toolchains/llvm/prebuilt/linux-x86_64 --sysroot=/home/astaikos/Android/Sdk/ndk/21.0.6113669/toolchains/llvm/prebuilt/linux-x86_64/sysroot -fPIC -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -std=c++17 -DANDROID_STL=c++_shared -DMRS_USE_STR_WRAPPER -DMR_SHARING_ANDROID -DWEBRTC_POSIX -DWEBRTC_ANDROID -O0 -fno-limit-debug-info -Wl,--exclude-libs,libgcc_real.a -Wl,--exclude-libs,libatomic.a -static-libstdc++ -Wl,--build-id -Wl,--fatal-warnings -Wl,--no-undefined -Qunused-arguments -shared -Wl,-soname,libmrwebrtc.so -o /home/astaikos/eanders/MixedReality-WebRTC/tools/build/android/webrtc-native/build/intermediates/cmake/debug/obj/arm64-v8a/libmrwebrtc.so CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/interop/external_video_track_source_interop.cpp.o CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/interop/global_factory.cpp.o CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/interop/local_video_track_interop.cpp.o CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/interop/peer_connection_interop.cpp.o CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/interop/interop_api.cpp.o CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/media/external_video_track_source.cpp.o CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/media/local_video_track.cpp.o CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/audio_frame_observer.cpp.o CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/data_channel.cpp.o CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/mrs_errors.cpp.o CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/pch.cpp.o CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/peer_connection.cpp.o CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/sdp_utils.cpp.o CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/str.cpp.o CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/video_frame_observer.cpp.o CMakeFiles/mrwebrtc.dir/jni_onload.cpp.o -llog -landroid -ldl -lOpenSLES /home/astaikos/eanders/build_webrtc/webrtc/src/out/android/arm64/Release/obj/libwebrtc.a -latomic -lm && :
CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/peer_connection.cpp.o: In function PeerConnection': /home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/peer_connection.cpp:1370: undefined reference to Microsoft::MixedReality::WebRTC::TrackedObject::TrackedObject(Microsoft::MixedReality::WebRTC::RefPtrMicrosoft::MixedReality::WebRTC::GlobalFactory, Microsoft::MixedReality::WebRTC::ObjectType)'
CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/peer_connection.cpp.o: In function ~PeerConnection': /home/astaikos/eanders/MixedReality-WebRTC/tools/build/android/webrtc-native/src/main/cpp/../../../../../../../libs/Microsoft.MixedReality.WebRTC.Native/src/peer_connection.h:65: undefined reference to Microsoft::MixedReality::WebRTC::TrackedObject::~TrackedObject()'
CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/peer_connection.cpp.o:(.data.rel.ro._ZTIN9Microsoft12MixedReality6WebRTC14PeerConnectionE[_ZTIN9Microsoft12MixedReality6WebRTC14PeerConnectionE]+0x10): undefined reference to typeinfo for Microsoft::MixedReality::WebRTC::TrackedObject' CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/media/external_video_track_source.cpp.o: In function ExternalVideoTrackSource':
/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/media/external_video_track_source.cpp:287: undefined reference to Microsoft::MixedReality::WebRTC::TrackedObject::TrackedObject(Microsoft::MixedReality::WebRTC::RefPtr<Microsoft::MixedReality::WebRTC::GlobalFactory>, Microsoft::MixedReality::WebRTC::ObjectType)' CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/media/external_video_track_source.cpp.o: In function ~ExternalVideoTrackSource':
/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/media/external_video_track_source.h:79: undefined reference to Microsoft::MixedReality::WebRTC::TrackedObject::~TrackedObject()' CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/media/external_video_track_source.cpp.o:(.data.rel.ro._ZTIN9Microsoft12MixedReality6WebRTC24ExternalVideoTrackSourceE[_ZTIN9Microsoft12MixedReality6WebRTC24ExternalVideoTrackSourceE]+0x10): undefined reference to typeinfo for Microsoft::MixedReality::WebRTC::TrackedObject'
CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/media/local_video_track.cpp.o: In function LocalVideoTrack': /home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/media/local_video_track.cpp:18: undefined reference to Microsoft::MixedReality::WebRTC::TrackedObject::TrackedObject(Microsoft::MixedReality::WebRTC::RefPtrMicrosoft::MixedReality::WebRTC::GlobalFactory, Microsoft::MixedReality::WebRTC::ObjectType)'
/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/media/local_video_track.cpp:27: undefined reference to Microsoft::MixedReality::WebRTC::TrackedObject::~TrackedObject()' CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/media/local_video_track.cpp.o: In function ~LocalVideoTrack':
/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/media/local_video_track.cpp:35: undefined reference to Microsoft::MixedReality::WebRTC::TrackedObject::~TrackedObject()' /home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/media/local_video_track.cpp:35: undefined reference to Microsoft::MixedReality::WebRTC::TrackedObject::~TrackedObject()'
CMakeFiles/mrwebrtc.dir/home/astaikos/eanders/MixedReality-WebRTC/libs/Microsoft.MixedReality.WebRTC.Native/src/media/local_video_track.cpp.o:(.data.rel.ro._ZTIN9Microsoft12MixedReality6WebRTC15LocalVideoTrackE+0x28): undefined reference to `typeinfo for Microsoft::MixedReality::WebRTC::TrackedObject'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

I fixed that like 5 min ago, this was due to the merge of master, you're too fast... 😉

I'm also attempting to build for android, via android studio. but I'm coming across the following error:
In file included from C:\MixedRealityRTCLib\MixedReality-WebRTC\libs\Microsoft.MixedReality.WebRTC.Native\src\media\external_video_track_source.cpp:4:
C:\MixedRealityRTCLib\MixedReality-WebRTC\libs\Microsoft.MixedReality.WebRTC.Native\src\pch.h:44:10: fatal error: 'api/audio_codecs/builtin_audio_decoder_factory.h' file not found

is there some include directive that is missing? I've pulled from the 'master' branch.

djee-ms · 2020-03-26T11:51:46Z

tools/build/android/README.md

+        * NDK 16.1.4479499
+    * JRE 1.8 (https://www.java.com/download/)
+
+3. Add environment variable JAVA_HOME pointing to your JRE install directory. e.g.: `JAVA_HOME="C:\Program Files\Android\Android Studio\jre"`


On Linux that's apt install openjdk-8-jre and I think already installed by the Google dependency script. Shall we mention it for completeness?

I noted later that this is also needed on Unity, although Unity will strongly suggest using the version shipped with the Unity Editor. Maybe we should recommend that too, or at least point it out.

libs/Microsoft.MixedReality.WebRTC/Interop/InteropUtils.cs

Due to a bug in P/Invoke on Windows, which prevents loading DLLs by name without extension when the filename contains some dot '.' character, and in order to keep the Microsoft.MixedReality.WebRTC assembly fully cross-platform, this change renames the native implementation DLL from Microsoft.MixedReality.WebRTC.Native.dll into mrwebrtc.dll. This has the added benefit to make it clear that this is not anymore the C++ library, but an opaque internal implementation. The C++ library will, like the C# one, build on top of that implementation DLL.

It seems the explicit reference was not needed before, but at least in Unity 2019.3 the test assemblies will fail to build without this reference.

Check during config.sh that the host machine pass some basic requirements when configuring an Android build, to avoid starting a lengthy task that cannot possibly complete: - Host needs to run a particular Linux distro supported by the Google scripts. This can be ignored with the -u option. - Host needs at least 40GB of disk space to build everything needed. This can be ignored with the -s option.

No longer necessary. See #193 (comment) for details.

eanders-ms added 19 commits December 11, 2019 11:47

Android build wip

aafe825

Noodling on Android build dependencies

49ec158

Add some build hints in comments

dbef23d

Android build updates

3048bea

Android build updates

b8f3835

Merge branch 'master' into eanders/android

1ae97db

Update android build

2cb1213

Update android module name

d729d1c

Updated build scripts -- wip

003599e

Fix build warnings

f0e2c05

The Android build lives again

3d97112

Delete unused code

3afba6c

doc tweak

6a49e0a

script tweak

80d34c1

doc tweak

e01d06a

Initial Android build of Unity sample

c2d42c8

More build script refinements

9e276fd

Merge branch 'master' into eanders/android

6414804

Delete gitignore

7366f5d

eanders-ms requested a review from djee-ms February 19, 2020 01:47

djee-ms self-assigned this Feb 19, 2020

djee-ms added the enhancement New feature or request label Feb 19, 2020

djee-ms added this to the 2.0.0 milestone Feb 19, 2020

djee-ms linked an issue Feb 19, 2020 that may be closed by this pull request

Support iOS and Android SDK #28

Open

djee-ms reviewed Feb 19, 2020

View reviewed changes

stephenatwork reviewed Feb 19, 2020

View reviewed changes

projects/android/gradlew Outdated Show resolved Hide resolved

Move projects folder contents to tools/build

e79555d

eanders-ms changed the title ~~[wip] Android support~~ Android support Feb 19, 2020

Restore [[nodiscard]]

b76efb4

eanders-ms commented Mar 10, 2020

View reviewed changes

...ty.WebRTC.Unity/Assets/Microsoft.MixedReality.WebRTC.Unity/Scripts/Media/LocalAudioSource.cs Show resolved Hide resolved

eanders-ms marked this pull request as ready for review March 10, 2020 16:55

djee-ms mentioned this pull request Mar 10, 2020

WIndows Standalone Build calling UWP Hololens Build #216

Closed

djee-ms mentioned this pull request Mar 19, 2020

Android Video Stream problem when in portrait mode #231

Open

djee-ms suggested changes Mar 25, 2020

View reviewed changes

djee-ms reviewed Mar 25, 2020

View reviewed changes

tools/build/libwebrtc/lib.sh Outdated Show resolved Hide resolved

djee-ms reviewed Mar 26, 2020

View reviewed changes

libs/Microsoft.MixedReality.WebRTC/Interop/InteropUtils.cs Outdated Show resolved Hide resolved

djee-ms removed a link to an issue Mar 27, 2020

Support iOS and Android SDK #28

Open

djee-ms added 10 commits March 27, 2020 17:33

Make libwebrtc build scripts executable by default

2520c16

Add missing ref from Unity tests to C# library

571589e

It seems the explicit reference was not needed before, but at least in Unity 2019.3 the test assemblies will fail to build without this reference.

Don't silently accept EULA for user

1649b59

Manually fix conflict in .gitignore before merging

c4b9bf3

Merge branch 'master' into eanders/android

5657220

Rename of mrwebrtc.dll for TestNetCoreConsole

3866109

Merge master into eanders/android

21dfa1d

Fix Android CMakeLists.txt after master merge

91ccffc

djee-ms approved these changes Mar 31, 2020

View reviewed changes

This was referenced Mar 31, 2020

Add video capture on Android #246

Closed

Reduce Android archives size #247

Closed

Merge the two Android archives into a single one #248

Closed

djee-ms merged commit 9a50602 into microsoft:master Mar 31, 2020

fibann added a commit that referenced this pull request Apr 14, 2020

Remove SdpTypeFromString copy

112b6ea

No longer necessary. See #193 (comment) for details.

eanders-ms deleted the eanders/android branch April 14, 2020 21:24

HyperLethalVector mentioned this pull request Apr 30, 2020

Building for Android: #312

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android support #193

Android support #193

eanders-ms commented Feb 19, 2020 •

edited

Loading

eanders-ms commented Feb 19, 2020 via email •

edited

Loading

djee-ms left a comment

astaikos316 commented Mar 9, 2020

djee-ms commented Mar 9, 2020

djee-ms Mar 25, 2020

eanders-ms Mar 26, 2020

djee-ms Mar 28, 2020

djee-ms Mar 26, 2020

djee-ms Mar 26, 2020

eanders-ms Mar 26, 2020

djee-ms Mar 27, 2020

astaikos316 Mar 31, 2020

djee-ms Mar 31, 2020

HyperLethalVector Apr 12, 2020

djee-ms Mar 26, 2020

djee-ms Mar 26, 2020

Android support #193

Android support #193

Conversation

eanders-ms commented Feb 19, 2020 • edited Loading

eanders-ms commented Feb 19, 2020 via email • edited Loading

djee-ms left a comment

Choose a reason for hiding this comment

astaikos316 commented Mar 9, 2020

djee-ms commented Mar 9, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eanders-ms commented Feb 19, 2020 •

edited

Loading

eanders-ms commented Feb 19, 2020 via email •

edited

Loading