This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
Init/close PeerConnection on enable/disable #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djee-ms
suggested changes
Jun 26, 2020
Ensure proper shutdown across MediaLines & co. Removed AutoInitializeOnStart, and made Initialize/Uninitialize private, now PC should be turned on/off by enabling/disabling. We now create/keep local tracks only when there are both a live source and a connection. Therefore, local tracks do not persist after the PeerConnection component is disabled. This is intended, as we cannot keep the track and attach it to a different PeerConnection if the component is re-enabled. Removed listeners to tracks removed. Unpairing is handled manually on renegotiation and on shutdown (MediaLine.UnpairTransceiver).
Avoid accumulating a lot of game objects when running multiple tests in a row, makes test shutdown faster
fibann
force-pushed
the
unity-pc-shutdown
branch
from
3181e3f
to
4c1ba8d
Compare
djee-ms
approved these changes
Jul 18, 2020
Co-authored-by: Jerome Humbert <jerome.humbert@microsoft.com>
Co-authored-by: Jerome Humbert <jerome.humbert@microsoft.com>
Co-authored-by: Jerome Humbert <jerome.humbert@microsoft.com>
I have changed There turned out to be a bug there, fix is now up (plus tests). |
mr-webrtc-buildbot
added a commit
that referenced
this pull request
Jul 20, 2020
…n/unity-pc-shutdown)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure proper shutdown across MediaLines & co.
Removed AutoInitializeOnStart, and made Initialize/Uninitialize private,
now PC should be turned on/off by enabling/disabling.
We now create/keep local tracks only when there are both a live source and a
connection. Therefore, local tracks do not persist after the PeerConnection
component is disabled. This is intended, as we cannot keep the track and
attach it to a different PeerConnection if the component is re-enabled.
Removed listeners to tracks removed. Unpairing is handled manually on
renegotiation and on shutdown (MediaLine.UnpairTransceiver).
Fix #375.