Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectator View Bug Fixes #66

Merged
merged 2 commits into from
Mar 11, 2017
Merged

Spectator View Bug Fixes #66

merged 2 commits into from
Mar 11, 2017

Conversation

fieldsJacksonG
Copy link
Contributor

  • Increase video bitrate to respect video fps.
  • Detect video format based on FRAME_HEIGHT to prevent blackmagic from using a smaller frame.
  • Potentially fix audio issues with a larger bitrate.

#62
#63
potentially addressing
#64

+ Increase video bitrate to respect video fps.
+ Detect video format based on FRAME_HEIGHT to prevent blackmagic from using a smaller frame.
+ Potentially fix audio issues with a larger bitrate.

#62
#63
potentially addressing
#64
@msftclas
Copy link

msftclas commented Mar 4, 2017

@fieldsJacksonG,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@jieseattle
Copy link

@fieldsJacksonG I can see you will still have fps issues - for example sometimes we need to use 25/50fps for PAL format. Is there a way to detect the frame rate also?

@fieldsJacksonG
Copy link
Contributor Author

Took a brief look at this - we may need to manually set the frame rate, either in the compositor or plumb the selection option through to the compositor window in Unity.

@jieseattle
Copy link

if we can have a drop down in compositor window that would be awesome.

@fieldsJacksonG
Copy link
Contributor Author

Drop down will be in a future commit - I will need to modify additional files to make that happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants