Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Haptics doesn't work when running in-editor #1440

Closed
keveleigh opened this issue Nov 26, 2017 · 2 comments
Closed

[master] Haptics doesn't work when running in-editor #1440

keveleigh opened this issue Nov 26, 2017 · 2 comments
Assignees
Projects

Comments

@keveleigh
Copy link
Contributor

Overview

The UWP haptics APIs are currently exposed in a way that makes them incompatible with running in the Unity editor.

My recommended fix would be by adding to the DLL (we can rename it to make it more accurate) I wrote to expose the motion controller model API, found in the MixedRealityTookit here.

Additional methods could be written, with identical code to lines 18-39, but then calling the haptics APIs like in the existing Toolkit extensions.

I initially experimented with this addition when writing the initial DLL, but remember being blocked around creating a TimeSpan object, without time at the time to fully investigate.

Expected Behavior

The haptics APIs work when running in the editor.

Actual Behavior

The haptics APIs only work in a deployed app.

Steps to reproduce

Run the MotionControllerTest scene and press grasp or menu to try to trigger haptics.

Unity Editor Version

All

Mixed Reality Toolkit Release Version

All

@StephenHodgson
Copy link
Contributor

Any way we can extend this to also tie in haptics from non spatial controllers as well?

@keveleigh
Copy link
Contributor Author

Yeah, maybe we can use the UWP GamePad Vibration APIs or the SimpleHapticsControllers from the UWP RawGameController APIs to expose haptics there as well.

@david-c-kline david-c-kline changed the title Haptics doesn't work when running in-editor [master] Haptics doesn't work when running in-editor Mar 22, 2018
@david-c-kline david-c-kline added this to To do in 2017.2.1.4 via automation Mar 26, 2018
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this issue Mar 26, 2018
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this issue Mar 26, 2018
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this issue Mar 26, 2018
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this issue Mar 26, 2018
@david-c-kline david-c-kline moved this from To do to In progress in 2017.2.1.4 Mar 28, 2018
2017.2.1.4 automation moved this from In progress to Done Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2017.2.1.4
  
Done
Development

No branches or pull requests

3 participants