Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoloToolkit-Example TextPrefabSamplesTest broken with Missing Prefab error #346

Closed
NeerajW opened this issue Nov 28, 2016 · 8 comments
Closed
Assignees

Comments

@NeerajW
Copy link

NeerajW commented Nov 28, 2016

Repro steps:

  1. Sync to latest master HTK-U
  2. Open project using Unity 5.4 releases
  3. Open HoloToolkit-Examples\Text\TextPrefabSamplesTest scene

Observe issue:
image

I guess this could be due to either some different version of Unity being used to check in or may be the font dependency? The original prefabs look fine though. It's hard to tell what these prefabs are.

@cre8ivepark
Copy link
Contributor

cre8ivepark commented Nov 28, 2016

@NeerajW Those are the four text & sample prefabs added as part of #339
This test scene is just having them in the hierarchy. Let me try with different version.
2016-11-28 13_49_25-unity personal 64bit - textprefabsamplestest unity - textprefabtest5 - pc mac

@NeerajW
Copy link
Author

NeerajW commented Nov 28, 2016

@dbastienMS just mentioned to me that you might be missing meta files.
True indeed: You don't have a meta file checked in for TextPrefabSamplesTest.meta
Also missing meta files for you 3DTextPrefab and other files.
Please add the meta files for all of them.

@cre8ivepark
Copy link
Contributor

Created new pull request with added .meta files.
Thank you!

@NeerajW
Copy link
Author

NeerajW commented Nov 28, 2016

Still broken. Looks like there is a Scripts.meta but no Scripts folder to go with it.

@NeerajW
Copy link
Author

NeerajW commented Nov 29, 2016

Great. That issue is now fixed :)
Only new issue I see in the test scene is:

3DTextPrefab is missing the shader. This shader does not exist on the main prefab in UI\Prefabs.
Perhaps this needs to be fixed:

  1. To point to HoloToolkit\3DTextShader
  2. Also apply this same shader to the prefab

image

@StephenHodgson
Copy link
Contributor

@NeerajW the shader probably just needs to be recompiled.

NeerajW added a commit that referenced this issue Nov 29, 2016
@NeerajW
Copy link
Author

NeerajW commented Nov 29, 2016

@HodgsonSDAS nope. There was a shader namespace change and it had to be re-applied to the component.

@NeerajW
Copy link
Author

NeerajW commented Nov 29, 2016

Fixed with PR #351

@NeerajW NeerajW closed this as completed Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants