Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hand menu should not show up if user is manipulating something with hands #5257

Closed
julenka opened this issue Jul 10, 2019 · 0 comments
Closed

Comments

@julenka
Copy link
Contributor

julenka commented Jul 10, 2019

Overview

The hand menu shows up when users grab and manipulate objects. The menu should now show up if a pointer is locked / if a hand is manipulating something.

@julenka julenka added the Bug label Jul 10, 2019
@Cameron-Micka Cameron-Micka self-assigned this Jul 23, 2019
julenka pushed a commit that referenced this issue Aug 9, 2019
## Overview
This pull request moves the HandConstraint  (and HandConstraintPalmUp) solver from Experimental to Release by adding tests, documentation, and a handful of bug fixes and improvements. Functionality remains pretty much the same from the previous pull request (#4532) and utilizes solver fixes from @Troy-Ferrell's (#5416)

The solver has also be genericized to work with motion controllers.

Thank you @julenka for guidance on how to write unit tests that utilize hands!

## Changes
- Fixes: #5312, #5304, #5257, #5413


## Commits
* Removing global input handler warning.

* Wip check-in, new rotation behavior.

* Disable hand tracking on hands which are currently focus locked.

* Adding additional hand menu features and documentation improvements.

* Hand constraint example improvements.

* Hacks to get solver to not throw null pointers when instantiated. Should be reverted

* Skeleton test for ensuring hand menu follows hand

* Comment and example improvements.

* autoTransitionBetweenHands is now set via the tracked handness of the solver handler

* Adding support for motion controllers.

* Updating example to support new solver changes.

* Moving hand based menus out of the experimental namespace.

* Adding hand constraint documentation.

* Addressing pr feedback.

* Updating example scene to use "new" toggle buttons.

* Improving documentation, especially around IMixedRealityControllers usage.

* Fixing broken documentation.

* Update Documentation/README_Solver.md
MenelvagorMilsom added a commit that referenced this issue Aug 9, 2019
…Constraint (and HandConstraintPalmUp) solver from Experimental to Release by adding tests, documentation, and a handful of bug fixes and improvements. Functionality remains pretty much the same from the previous pull request (#4532) and utilizes solver fixes from @Troy-Ferrell's (#5416)  The solver has also be genericized to work with motion controllers.  Thank you @julenka for guidance on how to write unit tests that utilize hands!  ## Changes - Fixes: #5312, #5304, #5257, #5413   ## Commits * Removing global input handler warning.  * Wip check-in, new rotation behavior.  * Disable hand tracking on hands which are currently focus locked.  * Adding additional hand menu features and documentation improvements.  * Hand constraint example improvements.  * Hacks to get solver to not throw null pointers when instantiated. Should be reverted  * Skeleton test for ensuring hand menu follows hand  * Comment and example improvements.  * autoTransitionBetweenHands is now set via the tracked handness of the solver handler  * Adding support for motion controllers.  * Updating example to support new solver changes.  * Moving hand based menus out of the experimental namespace.  * Adding hand constraint documentation.  * Addressing pr feedback.  * Updating example scene to use new toggle buttons.  * Improving documentation, especially around IMixedRealityControllers usage.  * Fixing broken documentation.  * Update Documentation/README_Solver.md )
julenka pushed a commit to julenka/MixedRealityToolkit-Unity that referenced this issue Aug 9, 2019
…oft#5500)

## Overview
This pull request moves the HandConstraint  (and HandConstraintPalmUp) solver from Experimental to Release by adding tests, documentation, and a handful of bug fixes and improvements. Functionality remains pretty much the same from the previous pull request (microsoft#4532) and utilizes solver fixes from @Troy-Ferrell's (microsoft#5416)

The solver has also be genericized to work with motion controllers.

Thank you @julenka for guidance on how to write unit tests that utilize hands!

## Changes
- Fixes: microsoft#5312, microsoft#5304, microsoft#5257, microsoft#5413


## Commits
* Removing global input handler warning.

* Wip check-in, new rotation behavior.

* Disable hand tracking on hands which are currently focus locked.

* Adding additional hand menu features and documentation improvements.

* Hand constraint example improvements.

* Hacks to get solver to not throw null pointers when instantiated. Should be reverted

* Skeleton test for ensuring hand menu follows hand

* Comment and example improvements.

* autoTransitionBetweenHands is now set via the tracked handness of the solver handler

* Adding support for motion controllers.

* Updating example to support new solver changes.

* Moving hand based menus out of the experimental namespace.

* Adding hand constraint documentation.

* Addressing pr feedback.

* Updating example scene to use "new" toggle buttons.

* Improving documentation, especially around IMixedRealityControllers usage.

* Fixing broken documentation.

* Update Documentation/README_Solver.md
julenka pushed a commit that referenced this issue Aug 9, 2019
…#5560)

* Moving the HandConstraint Solver from Experimental to Release (#5500)

## Overview
This pull request moves the HandConstraint  (and HandConstraintPalmUp) solver from Experimental to Release by adding tests, documentation, and a handful of bug fixes and improvements. Functionality remains pretty much the same from the previous pull request (#4532) and utilizes solver fixes from @Troy-Ferrell's (#5416)

The solver has also be genericized to work with motion controllers.

Thank you @julenka for guidance on how to write unit tests that utilize hands!

## Changes
- Fixes: #5312, #5304, #5257, #5413


## Commits
* Removing global input handler warning.

* Wip check-in, new rotation behavior.

* Disable hand tracking on hands which are currently focus locked.

* Adding additional hand menu features and documentation improvements.

* Hand constraint example improvements.

* Hacks to get solver to not throw null pointers when instantiated. Should be reverted

* Skeleton test for ensuring hand menu follows hand

* Comment and example improvements.

* autoTransitionBetweenHands is now set via the tracked handness of the solver handler

* Adding support for motion controllers.

* Updating example to support new solver changes.

* Moving hand based menus out of the experimental namespace.

* Adding hand constraint documentation.

* Addressing pr feedback.

* Updating example scene to use "new" toggle buttons.

* Improving documentation, especially around IMixedRealityControllers usage.

* Fixing broken documentation.

* Update Documentation/README_Solver.md

* Update Documentation/README_Solver.md

Co-Authored-By: David Kline <davidkl@microsoft.com>
MenelvagorMilsom added a commit that referenced this issue Aug 9, 2019
…rimental to Release (#5500)  ## Overview This pull request moves the HandConstraint  (and HandConstraintPalmUp) solver from Experimental to Release by adding tests, documentation, and a handful of bug fixes and improvements. Functionality remains pretty much the same from the previous pull request (#4532) and utilizes solver fixes from @Troy-Ferrell's (#5416)  The solver has also be genericized to work with motion controllers.  Thank you @julenka for guidance on how to write unit tests that utilize hands!  ## Changes - Fixes: #5312, #5304, #5257, #5413   ## Commits * Removing global input handler warning.  * Wip check-in, new rotation behavior.  * Disable hand tracking on hands which are currently focus locked.  * Adding additional hand menu features and documentation improvements.  * Hand constraint example improvements.  * Hacks to get solver to not throw null pointers when instantiated. Should be reverted  * Skeleton test for ensuring hand menu follows hand  * Comment and example improvements.  * autoTransitionBetweenHands is now set via the tracked handness of the solver handler  * Adding support for motion controllers.  * Updating example to support new solver changes.  * Moving hand based menus out of the experimental namespace.  * Adding hand constraint documentation.  * Addressing pr feedback.  * Updating example scene to use new toggle buttons.  * Improving documentation, especially around IMixedRealityControllers usage.  * Fixing broken documentation.  * Update Documentation/README_Solver.md  * Update Documentation/README_Solver.md  Co-Authored-By: David Kline <davidkl@microsoft.com> )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants