Mic sample fix #10362
Merged
Mic sample fix #10362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-c-kline
requested review from
CDiaz-MS,
cre8ivepark,
julenka,
keveleigh,
macborow and
MenelvagorMilsom
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
keveleigh
reviewed
Dec 9, 2021
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
MaxWang-MS
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the Windows Mic Stream demo when imported using UPM packages by creating a new assembly definition for the application and referencing / checking for the com.microsoft.mixedreality.toolkit.micstream package.
Previous references in the root examples assembly definition have been removed.
Changes
Verification
Side-loaded test packages, imported Demos - Audio, deployed to HoloLens 2, talked quietly and loudly 馃槃