Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mesh when using app-based holographic remoting #10366

Merged
merged 8 commits into from
Dec 13, 2021

Conversation

keveleigh
Copy link
Contributor

@keveleigh keveleigh commented Dec 9, 2021

Overview

Updates our XRSDK-based mesh observers to:

  1. Properly refresh their mesh subsystem when XR is initialized after MRTK is initialized
  2. Ensure that more than one observer is not running when the "generic" observer is used with a more specific observer (like the one specific to OpenXR)
  3. Ensured that we don't try to use a mesh subsystem that isn't actively running. This was leading to
  4. Ensured that we don't try to set values on the mesh subsystem unless the app is running (the underlying bug here would probably also be solved by fix 3)

Changes

@keveleigh
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@keveleigh
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@keveleigh keveleigh merged commit 03e6296 into microsoft:releases/2.7.3 Dec 13, 2021
@keveleigh keveleigh deleted the fix-mesh branch December 13, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants