Fix single-frame cursor flickering #10436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Cameron-Micka
approved these changes
Feb 3, 2022
|
Appreciate the contribution! Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The offending cursor prefabs have by default their visuals enabled. When handtracking starts and the cursors are spawned, it takes the system a frame to figure out they're not needed and to disable them. This results in the cursors flashing.
The solution is to simply check
disableCursorOnStartfor the offending cursors and have the visuals properly disabled for the poke pointer (properly as in not only a transparent material, but disabling the visuals GameObject).The latter change also fixes a cutout on your index finger when using the handmesh visualization:
After - Before:
Changes