Update OnInspectorGUI for Toolkit Inspector

[Proton-V]

Changes

• Fixes: Changing profile at runtime with MixedRealityToolkit.Instance.ActiveProfile = profileToUse; throws NullReferenceException #10720

Overview

Fixed micro issue with MixedRealityToolkit Inspector
Issue: error stack when we have active MixedRealityToolkit Inspector in editor and active profile is changed

Fixes

• OnInspectorGUI method in MixedRealityToolkitInspector.cs

[MaxWang-MS]

Hi @Proton-V, thanks for opening the PR. I think by adding the if statement you are limiting the ability to switch profiles in the inspector to only when the application is not in play mode. I would propose adding an else statement containing the following call:
MixedRealityToolkit.Instance.ActiveProfile = (MixedRealityToolkitConfigurationProfile)activeProfile.objectReferenceValue;
This way one can also switch profiles in the inspector while the application is in play mode.

[Proton-V]

@MaxWang-MS Hello. Of course, you're right, thanks!

[MaxWang-MS]

Thanks for the contribution! Just curious, have you run into situations where an exception was thrown? I am wondering why you added the try catch.

[Proton-V]

Thanks for the contribution! Just curious, have you run into situations where an exception was thrown? I am wondering why you added the try catch.

I added this for future changes.
Possible that these methods may sometimes work incorrectly (later, currently i dont see this behaviour).

And i think handling error without stop action - normal way.

@MaxWang-MS
Tell me what do you think about it. I will be glad to hear your thought

[MaxWang-MS]

Thanks for the contribution! Just curious, have you run into situations where an exception was thrown? I am wondering why you added the try catch.

I added this for future changes. Possible that these methods may sometimes work incorrectly (later, currently i dont see this behaviour).

And i think handling error without stop action - normal way.

@MaxWang-MS Tell me what do you think about it. I will be glad to hear your thought

I don't have a super strong opinion on this, but in general I tend to use try catch when I expect things to sometimes go wrong. At the moment I don't really expect exceptions to be thrown when the profile change is initiated the correct way, so I was wondering why you added them. I don't think it hurts to keep them here though.