Move some codepaths away from MixedRealityToolkitFiles #10956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keveleigh
requested review from
david-c-kline and
MenelvagorMilsom
as code owners
keveleigh
force-pushed
the
absolute-paths
branch
from
b86d9b6
to
a8125a6
Compare
david-c-kline
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
MixedRealityToolkitFiles has always had some issues around Assets vs Packages, relative vs absolute, and some less-standard forms of referencing MRTK2.
This PR moves away from most of the more problematic cases for in-MRTK code to use Unity's
AssetDatabaseAPIs instead.Changes