Fixing issues with constraints and off-center ObjManip host transforms #11086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zee2
added
the
UX Controls - ObjectManipulator
keveleigh
reviewed
Oct 6, 2022
com.microsoft.mrtk.spatialmanipulation/ObjectManipulator/ObjectManipulator.cs
Show resolved
Hide resolved
RogPodge
previously requested changes
Oct 6, 2022
com.microsoft.mrtk.spatialmanipulation/ObjectManipulator/ObjectManipulator.cs
Show resolved
Hide resolved
Zee2
force-pushed
the
constraint_offset_fix
branch
from
76e2df0
to
4f22f29
Compare
RogPodge
approved these changes
Oct 13, 2022
|
Looks great! |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drusk-unity
pushed a commit
to drusk-unity/MixedRealityToolkit-Unity
that referenced
this pull request
Jun 26, 2023
microsoft#11086) * Fixing constraint execution conflict w/ user input * Cleanup * Comment fix Co-authored-by: RogPodge <39840334+RogPodge@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Because all three forms of user input (scale, rotation, position) were computed first, and then all of the constraints were computed afterwards, the position input was calculated without the knowledge of the scale constraint. This resulted in strange behaviors when the user tried to scale an object past a MinMaxScaleConstraint's limits.
Changes
@JonathanPalmerGD here you go!