Add a null-check of TeleportMarker before instantiating the object. #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| else | ||
| { | ||
| fadeMaterial = GetComponentInChildren<MeshRenderer>().material; |
There was a problem hiding this comment.
.material is bad unless we're destroying the fade material later.
| @@ -90,7 +99,7 @@ void CalculateFade() | |||
|
|
|||
| protected override void OnDestroy() | |||
| { | |||
| if (fadeMaterial != null) | |||
| if (fadeMaterial != null && !FadeSharedMaterial) | |||
| { | |||
| Destroy(fadeMaterial); | |||
StephenHodgson
approved these changes
Oct 11, 2017
|
We could put this on the master branch, if we get the back port in soon. |
keveleigh
approved these changes
Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1112 Added a null-check of TeleportMarker before instantitiating the object.
Fixes #1113 Add an option to use sharedMaterial when fading.