Add button to populate the profile field with the MRTK default #11259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I might be misinterpreting your description but doesn't this button show the assets from the immutable folder?
Super happy for this button though! |
Zee2
approved these changes
Dec 1, 2022
|
@Zee2 No way! 🤯 You learn something new every day! Thanks!
|
drusk-unity
pushed a commit
to drusk-unity/MixedRealityToolkit-Unity
that referenced
this pull request
Jun 26, 2023
…soft#11259) * Update MRTKProfileInspector.cs * Add button to populate the profile field with the MRTK default * Prevent a null ref in the case of null profile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Unfortunately, when consuming MRTK via tarballs, Unity's asset picker doesn't include assets from immutable folders...
This change adds a button to the MRTK Profile inspector to auto-populate the field with the default profile that we ship
I also changed some asserts to full
if/logs to prevent null refs and changed a class frominternaltoprivateto better fit its usage.