Audio spatializer support part 1: configuration script and update spatializer #11271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-c-kline
requested review from
keveleigh,
maluoi,
MaxWang-MS,
RogPodge and
Zee2
as code owners
Zee2
reviewed
Dec 6, 2022
Zee2
reviewed
Dec 6, 2022
Zee2
reviewed
Dec 6, 2022
Zee2
reviewed
Dec 6, 2022
Zee2
reviewed
Dec 6, 2022
com.microsoft.mrtk.core/Utilities/ConfigureSpaitializationSettings.cs
Outdated
Show resolved
Hide resolved
Zee2
reviewed
Dec 6, 2022
com.microsoft.mrtk.core/Utilities/ConfigureSpaitializationSettings.cs
Outdated
Show resolved
Hide resolved
Zee2
suggested changes
Dec 6, 2022
added 3 commits
December 5, 2022 16:35
Zee2
reviewed
Dec 6, 2022
Zee2
reviewed
Dec 6, 2022
Zee2
previously approved these changes
Dec 6, 2022
Zee2
reviewed
Dec 6, 2022
com.microsoft.mrtk.core/Utilities/ConfigureSpaitializationSettings.cs
Outdated
Show resolved
Hide resolved
Zee2
approved these changes
Dec 8, 2022
drusk-unity
pushed a commit
to drusk-unity/MixedRealityToolkit-Unity
that referenced
this pull request
Jun 26, 2023
…tializer (microsoft#11271) * enable auto-configuration of audio source, update spatializer * add flat stereo mixer group * rename file, fix silly mistake * pr feedback * fix manifest paths * pr feedback * pr feedback: cooler syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the Microsoft Spatializer to v2.37 which needs to be applied to a mixer group, rather than a game object. It also adds a mixer with two added groups (Spatialized and FlatStereo).
The new ConfigureSpatializationSettings script, when attached to a GameObject, will set the recommended settings for using the Microsoft Spatializer v2.