-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRTK3] SeeIt SayIt Example Scene #11446
Merged
marlenaklein-msft
merged 15 commits into
microsoft:mrtk3
from
marlenaklein-msft:PortSeeItSayItLabels
Apr 6, 2023
Merged
[MRTK3] SeeIt SayIt Example Scene #11446
marlenaklein-msft
merged 15 commits into
microsoft:mrtk3
from
marlenaklein-msft:PortSeeItSayItLabels
Apr 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlenaklein-msft
requested review from
AMollis,
shaynie and
srinjoym
as code owners
April 3, 2023 19:34
AMollis
requested changes
Apr 4, 2023
UnityProjects/MRTKDevTemplate/Assets/Prefabs/SeeItSayIt/AdjustLabelPosition.cs
Outdated
Show resolved
Hide resolved
UnityProjects/MRTKDevTemplate/Assets/Prefabs/SeeItSayIt/AdjustLabelPosition.cs
Outdated
Show resolved
Hide resolved
UnityProjects/MRTKDevTemplate/Assets/Prefabs/SeeItSayIt/AdjustLabelPosition.cs
Outdated
Show resolved
Hide resolved
UnityProjects/MRTKDevTemplate/Assets/Prefabs/SeeItSayIt/AdjustLabelPosition.cs
Outdated
Show resolved
Hide resolved
UnityProjects/MRTKDevTemplate/Assets/Prefabs/SeeItSayIt/AdjustLabelPosition.cs
Outdated
Show resolved
Hide resolved
AMollis
previously approved these changes
Apr 5, 2023
UnityProjects/MRTKDevTemplate/Assets/Scripts/AdjustLabelPosition.cs
Outdated
Show resolved
Hide resolved
UnityProjects/MRTKDevTemplate/Assets/Scripts/AdjustLabelPosition.cs
Outdated
Show resolved
Hide resolved
AMollis
approved these changes
Apr 5, 2023
drusk-unity
pushed a commit
to drusk-unity/MixedRealityToolkit-Unity
that referenced
this pull request
Jun 26, 2023
* Adds example scene to demonstrate use of the MRTK3 see-it, say-it label prefabs with canvas and non-canvas buttons. * Modifies see-it, say-it label canvas prefab to fix scale issue. * Configures the scene for voice commands and enables WindowKeywordRecognitionSubsystem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds an example scene to demonstrate use of the MRTK3 see-it say-it label prefabs with canvas and non-canvas buttons. On active hover, the see-it, say-it label is enabled. Known issue: timing difference between canvas and non-canvas buttons.
Also modifies see-it, say-it canvas prefab to fix scale issue.
Changes