Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MRTK3's minimum Unity version to 2021 LTS #11465

Merged
merged 29 commits into from
Apr 20, 2023

Conversation

shaynie
Copy link
Collaborator

@shaynie shaynie commented Apr 13, 2023

Overview

This PR removes support for 2020.x from MRTK3, in exchange for a large number of improvements from 2021

Changes

  • Bumps minimum Unity version of all MRTK3 packages to 2021.3
  • Upgrades sample project Unity version to 2021.3.22f1
  • Upgrades ARFoundation version to 5.0.5
  • Removes deprecated ARSessionOrigin from XR Rig
  • Reserializes all prefabs to the new serialization format
  • Fixes: Upgrade MRTK3's minimum Unity version to 2021 LTS #11422 .

Known issues

  • Need to upgrade build pipeline

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.

If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

srinjoym
srinjoym previously approved these changes Apr 18, 2023
README.md Show resolved Hide resolved
AMollis
AMollis previously approved these changes Apr 19, 2023
@AMollis AMollis merged commit 7df8a16 into microsoft:mrtk3 Apr 20, 2023
7 checks passed
@shaynie shaynie deleted the user/shaynie/u2021 branch April 21, 2023 17:40
drusk-unity pushed a commit to drusk-unity/MixedRealityToolkit-Unity that referenced this pull request Jun 26, 2023
* Update to Unity 2021.3.22f1

* package updates

* material changes

* re-serialize all prefabs with 2021

* Update OpenXR plugin to 1.8.0 and input system to 1.5.1

* Add updated OpenXR package

* Remaining settings for U2021.3

* Update unit tests to pass with the agressive caching in inputsystem 1.5.1

* Upgrade ARFoundation to 5.0.5

* Bump minimum Unity version for packages to 2021.3

* Update README and the minimum version dialog to require 2021.3

* Remove deprecated ARSessionOrigin from MRTK XR Rig prefab

* Update seeitsayit label tests to work with input system 1.5.1

* Fix seeitsayit label hover tests

* Remove extra debug text

* Update pipeline pool to Unity 2021.3.21f1

* Go back to microsoft mixedreality openxr package version 1.7.0.    Version 1.8.0 removed hand support for Android.

* Add hands and eye gaze interaction profiles for Windows standalone build

* Don't use WaitForEndOfFrame in tests.  https://forum.unity.com/threads/do-not-use-waitforendofframe.883648/

* Fix tests that need a little more time for simulated hand movement

* Some tests require more frames for simulated hand movements

* Add yet more time.  We need to add some hand move methods that just wait until they arrive at the requested positoin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants