Updated sample scene to support spatial audio #11469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlenaklein-msft
requested review from
AMollis,
shaynie and
srinjoym
as code owners
shaynie
approved these changes
Apr 18, 2023
AMollis
changed the title
AMollis
changed the title
drusk-unity
pushed a commit
to drusk-unity/MixedRealityToolkit-Unity
that referenced
this pull request
Jun 26, 2023
This PR updates MRTK3 sample scenes to enable spatial audio for all AudioSources and disables spatial audio on the non-canvas button prefab, to be consistent with the canvas button prefab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates MRTK3 sample scenes to add a mixer (the Microsoft Spatializer) and enable spatial audio, so that spatial audio will play for all AudioSources in all scenes.
Additionally, the non-canvas button prefab audio source defaulted to using spatial audio, without setting a mixer. This PR disables spatial audio on the non-canvas button prefab, to be consistent with the canvas button prefab.
Changes