Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 11208: Scale relative to the position of the interactors, not the attach points #11516

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

shaynie
Copy link
Collaborator

@shaynie shaynie commented Apr 25, 2023

Overview

Change ScaleLogic.cs to scale relative to the distance between two interactors instead of the distance between their attach points.

Changes

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.

If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

@shaynie shaynie merged commit 8bb2ef9 into microsoft:mrtk3 Apr 25, 2023
7 checks passed
@shaynie shaynie deleted the user/shaynie/11208Fix branch April 25, 2023 18:06
@thalbern
Copy link
Contributor

consider making this configurable to support both scenarios :)

drusk-unity pushed a commit to drusk-unity/MixedRealityToolkit-Unity that referenced this pull request Jun 26, 2023
… attach points (microsoft#11516)

Scale relative to the position of the interactors, not the attach points
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants